Skip to content

Added missing ngram properties #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 24, 2022

Conversation

tjoubert
Copy link
Contributor

@tjoubert tjoubert commented Dec 21, 2022

Added missing ngram properties
Solves issue #442

@tjoubert tjoubert requested a review from DiscoPYF December 21, 2022 17:29
@tjoubert tjoubert self-assigned this Dec 21, 2022
@tjoubert tjoubert linked an issue Dec 21, 2022 that may be closed by this pull request
Copy link
Collaborator

@DiscoPYF DiscoPYF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

There are a couple of other analyzer properties that are missing from this class (for other analyser types). Would have been worth adding them at the same time, but not a blocker.

@tjoubert tjoubert requested a review from DiscoPYF December 22, 2022 18:36
Copy link
Collaborator

@DiscoPYF DiscoPYF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me. Thanks @tjoubert

/// <summary>
/// Convert to all lower-case characters
/// </summary>
public const string CaseHandlingLower = "lower";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have been good to group the const together. I don't understand how they are grouped right now. But that doesn't really matter as we are going to review this in #450

@DiscoPYF DiscoPYF merged commit f7b0349 into master Dec 24, 2022
@DiscoPYF DiscoPYF deleted the DE-448-2-add-missing-analyzer-properties branch December 24, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missings mandatory attributes in AnalyzerProperties for ngram Analyzer
2 participants