Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests for ArangoDB 3.12 #499

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adds tests for ArangoDB 3.12 #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9d5e54f
Add tests for ArangoDB 3.12
DiscoPYF Feb 17, 2025
a3d25ae
Update older tests to run against latest minor.
DiscoPYF Feb 17, 2025
1248521
Mark PostTransactionAsync as deprecated since ArangoDB 3.12
DiscoPYF Feb 17, 2025
b3764df
Use enum values for error code assertions in GraphApiClientTest.
DiscoPYF Mar 9, 2025
b9e0280
Handle ArangoDB 3.12 breaking change for error code assertions in Gra…
DiscoPYF Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 43 additions & 22 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ workflows:
- "test-arangodb-3_11":
requires:
- build
- "test-arangodb-3_12":
requires:
- build

jobs:
build:
Expand All @@ -55,9 +58,9 @@ jobs:
docker:
- image: mcr.microsoft.com/dotnet/sdk:8.0
environment:
ARANGO_HOST: adb3_4_9
- image: arangodb:3.4.9
name: adb3_4_9
ARANGO_HOST: adb3_4
- image: arangodb:3.4
name: adb3_4
environment:
ARANGO_ROOT_PASSWORD: root
steps:
Expand All @@ -74,9 +77,9 @@ jobs:
docker:
- image: mcr.microsoft.com/dotnet/sdk:8.0
environment:
ARANGO_HOST: adb3_5_5
- image: arangodb:3.5.5
name: adb3_5_5
ARANGO_HOST: adb3_5
- image: arangodb:3.5
name: adb3_5
environment:
ARANGO_ROOT_PASSWORD: root
steps:
Expand All @@ -93,9 +96,9 @@ jobs:
docker:
- image: mcr.microsoft.com/dotnet/sdk:8.0
environment:
ARANGO_HOST: adb3_6_8
- image: arangodb/arangodb:3.6.8
name: adb3_6_8
ARANGO_HOST: adb3_6
- image: arangodb:3.6
name: adb3_6
environment:
ARANGO_ROOT_PASSWORD: root
steps:
Expand All @@ -112,9 +115,9 @@ jobs:
docker:
- image: mcr.microsoft.com/dotnet/sdk:8.0
environment:
ARANGO_HOST: adb3_7_17
- image: arangodb/arangodb:3.7.17
name: adb3_7_17
ARANGO_HOST: adb3_7
- image: arangodb:3.7
name: adb3_7
environment:
ARANGO_ROOT_PASSWORD: root
steps:
Expand All @@ -131,9 +134,9 @@ jobs:
docker:
- image: mcr.microsoft.com/dotnet/sdk:8.0
environment:
ARANGO_HOST: adb3_8_6
- image: arangodb/arangodb:3.8.6
name: adb3_8_6
ARANGO_HOST: adb3_8
- image: arangodb:3.8
name: adb3_8
environment:
ARANGO_ROOT_PASSWORD: root
steps:
Expand All @@ -150,9 +153,9 @@ jobs:
docker:
- image: mcr.microsoft.com/dotnet/sdk:8.0
environment:
ARANGO_HOST: adb3_9_1
- image: arangodb/arangodb:3.9.1
name: adb3_9_1
ARANGO_HOST: adb3_9
- image: arangodb:3.9
name: adb3_9
environment:
ARANGO_ROOT_PASSWORD: root
steps:
Expand All @@ -168,9 +171,9 @@ jobs:
docker:
- image: mcr.microsoft.com/dotnet/sdk:8.0
environment:
ARANGO_HOST: adb3_10_0
ARANGO_HOST: adb3_10
- image: arangodb:3.10
name: adb3_10_0
name: adb3_10
environment:
ARANGO_ROOT_PASSWORD: root
steps:
Expand All @@ -186,9 +189,27 @@ jobs:
docker:
- image: mcr.microsoft.com/dotnet/sdk:8.0
environment:
ARANGO_HOST: adb3_11_0
ARANGO_HOST: adb3_11
- image: arangodb:3.11
name: adb3_11_0
name: adb3_11
environment:
ARANGO_ROOT_PASSWORD: root
steps:
- attach_workspace:
# Must be absolute path or relative path from working_directory
at: ~/
- run:
name: Test
command: dotnet test -c Release --filter RunningMode!=Cluster

"test-arangodb-3_12":
working_directory: ~/arangodb-net-standard
docker:
- image: mcr.microsoft.com/dotnet/sdk:8.0
environment:
ARANGO_HOST: adb3_12
- image: arangodb:3.12
name: adb3_12
environment:
ARANGO_ROOT_PASSWORD: root
steps:
Expand Down
75 changes: 48 additions & 27 deletions arangodb-net-standard.Test/GraphApi/GraphApiClientTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
using System.Threading.Tasks;
using Xunit;

using static ArangoDBNetStandard.ArangoDBErrors;

namespace ArangoDBNetStandardTest.GraphApi
{
public class GraphApiClientTest : IClassFixture<GraphApiClientTestFixture>
Expand Down Expand Up @@ -81,7 +83,7 @@ public async Task DeleteGraphAsync_ShouldThrow_WhenNotFound()
});

Assert.Equal(HttpStatusCode.NotFound, exception.ApiError.Code);
Assert.Equal(1924, exception.ApiError.ErrorNum); // GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, exception.ApiError.ErrorNum);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱 Perhaps int constants would be better instead of enum values.

public static ArangoDBErrors
{
  public const int ERROR_GRAPH_NOT_FOUND = 1924;
}

It would be a breaking change in theory, but I can't imagine consumers doing anything else than int comparison against ApiErrorResponse.ErrorNum.

}

[Fact]
Expand All @@ -107,7 +109,7 @@ public async Task GetGraphAsync_ShouldThrow_WhenNotFound()
await _client.GetGraphAsync("bogus_graph");
});
Assert.Equal(HttpStatusCode.NotFound, exception.ApiError.Code);
Assert.Equal(1924, exception.ApiError.ErrorNum); // GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, exception.ApiError.ErrorNum);
}

[Fact]
Expand Down Expand Up @@ -164,7 +166,7 @@ public async Task GetVertexCollectionsAsync_ShouldThrow_WhenGraphDoesNotExist()
ApiErrorResponse apiError = ex.ApiError;

Assert.Equal(HttpStatusCode.NotFound, apiError.Code);
Assert.Equal(1924, apiError.ErrorNum);
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, apiError.ErrorNum);
}

[Fact]
Expand All @@ -184,7 +186,7 @@ public async Task GetEdgeCollectionsAsync_ShouldThrow_WhenGraphIsNotFound()
await _client.GetEdgeCollectionsAsync("bogus_graph");
});
Assert.Equal(HttpStatusCode.NotFound, exception.ApiError.Code);
Assert.Equal(1924, exception.ApiError.ErrorNum); // GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, exception.ApiError.ErrorNum);
}

[Fact]
Expand Down Expand Up @@ -309,7 +311,7 @@ await _client.PostEdgeDefinitionAsync(
});

Assert.Equal(HttpStatusCode.NotFound, exception.ApiError.Code);
Assert.Equal(1924, exception.ApiError.ErrorNum); // GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, exception.ApiError.ErrorNum);
}

[Fact]
Expand Down Expand Up @@ -361,7 +363,7 @@ public async Task PostVertexCollectionAsync_ShouldThrow_WhenGraphIsNotFound()

Assert.True(apiError.Error);
Assert.Equal(HttpStatusCode.NotFound, apiError.Code);
Assert.Equal(1924, apiError.ErrorNum); // ERROR_GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, apiError.ErrorNum);
}

[Fact]
Expand Down Expand Up @@ -411,7 +413,7 @@ public async Task PostVertexAsync_ShouldThrow_WhenGraphIsNotFound()

Assert.True(ex.ApiError.Error);
Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
Assert.Equal(1924, ex.ApiError.ErrorNum); // ERROR_GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, ex.ApiError.ErrorNum);
}

[Fact]
Expand All @@ -434,13 +436,17 @@ public async Task PostVertexAsync_ShouldThrow_WhenVertexCollectionIsNotFound()

Assert.True(ex.ApiError.Error);
Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
if (_fixture.VersionMajor >= 3 && _fixture.VersionMinor >= 10)

bool isVersion310Or311 = _fixture.VersionMajor == 3 &&
(_fixture.VersionMinor == 10 || _fixture.VersionMinor == 11);

if (isVersion310Or311)
{
Assert.Equal(1947, ex.ApiError.ErrorNum); //referenced vertex collection is not part of the graph
Assert.Equal((int)ERROR_GRAPH_REFERENCED_VERTEX_COLLECTION_NOT_USED, ex.ApiError.ErrorNum);
}
else
{
Assert.Equal(1203, ex.ApiError.ErrorNum); // ARANGO_DATA_SOURCE_NOT_FOUND
AssertVertexCollectionNotFound(ex.ApiError);
}
}

Expand Down Expand Up @@ -561,7 +567,7 @@ public async Task DeleteEdgeDefinitionAsync_ShouldThrow_WhenGraphNameDoesNotExis
});

Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
Assert.Equal(1924, ex.ApiError.ErrorNum); // GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, ex.ApiError.ErrorNum);
}

[Fact]
Expand Down Expand Up @@ -611,7 +617,7 @@ public async Task DeleteVertexCollectionAsync_ShouldThrow_WhenGraphIsNotFound()

Assert.True(ex.ApiError.Error);
Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
Assert.Equal(1924, ex.ApiError.ErrorNum); // ERROR_GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, ex.ApiError.ErrorNum);
}

[Fact]
Expand Down Expand Up @@ -671,7 +677,7 @@ public async Task DeleteVertexCollectionAsync_ShouldDropCollection_WhenDropColle
await _fixture.ArangoDBClient.Collection.GetCollectionAsync(clxToDelete);
});
Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
Assert.Equal(1203, ex.ApiError.ErrorNum); // ARANGO_DATA_SOURCE_NOT_FOUND
Assert.Equal((int)ERROR_ARANGO_DATA_SOURCE_NOT_FOUND, ex.ApiError.ErrorNum);
}

[Fact]
Expand Down Expand Up @@ -751,7 +757,7 @@ public async Task PostEdgeAsync_ShouldThrow_WhenGraphNotFound()
});

Assert.Equal(HttpStatusCode.NotFound, exception.ApiError.Code);
Assert.Equal(1924, exception.ApiError.ErrorNum); // GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, exception.ApiError.ErrorNum);
}

[Fact]
Expand Down Expand Up @@ -868,7 +874,7 @@ public async Task DeleteEdgeAsync_ShouldThrow_WhenGraphNotFound()
});

Assert.Equal(HttpStatusCode.NotFound, exception.ApiError.Code);
Assert.Equal(1924, exception.ApiError.ErrorNum); // GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, exception.ApiError.ErrorNum);
}

[Fact]
Expand Down Expand Up @@ -944,7 +950,7 @@ public async Task GetVertexAsync_ShouldThrow_WhenVertexCollectionIsNotFound()

Assert.True(ex.ApiError.Error);
Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
Assert.Equal(1203, ex.ApiError.ErrorNum); // ARANGO_DATA_SOURCE_NOT_FOUND
AssertVertexCollectionNotFound(ex.ApiError);
}

[Fact]
Expand Down Expand Up @@ -990,7 +996,7 @@ public async Task GetVertexAsync_ShouldThrow_WhenGraphIsNotFound()

Assert.True(ex.ApiError.Error);
Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
Assert.Equal(1924, ex.ApiError.ErrorNum); // ERROR_GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, ex.ApiError.ErrorNum);
}

[Fact]
Expand Down Expand Up @@ -1078,7 +1084,7 @@ public async Task DeleteVertexAsync_ShouldThrow_WhenGraphIsNotFound()

Assert.True(ex.ApiError.Error);
Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
Assert.Equal(1924, ex.ApiError.ErrorNum); // ERROR_GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, ex.ApiError.ErrorNum);
}

[Fact]
Expand All @@ -1101,7 +1107,7 @@ public async Task DeleteVertexAsync_ShouldThrow_WhenVertexCollectionIsNotFound()

Assert.True(ex.ApiError.Error);
Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
Assert.Equal(1203, ex.ApiError.ErrorNum); // ARANGO_DATA_SOURCE_NOT_FOUND
AssertVertexCollectionNotFound(ex.ApiError);
}

[Fact]
Expand Down Expand Up @@ -1231,7 +1237,7 @@ public async Task PatchVertexAsync_ShouldThrow_WhenGraphIsNotFound()

Assert.True(ex.ApiError.Error);
Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
Assert.Equal(1924, ex.ApiError.ErrorNum); // ERROR_GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, ex.ApiError.ErrorNum);
}

[Fact]
Expand All @@ -1254,7 +1260,7 @@ public async Task PatchVertexAsync_ShouldThrow_WhenVertexCollectionIsNotFound()

Assert.True(ex.ApiError.Error);
Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
Assert.Equal(1203, ex.ApiError.ErrorNum); // ARANGO_DATA_SOURCE_NOT_FOUND
AssertVertexCollectionNotFound(ex.ApiError);
}

[Fact]
Expand Down Expand Up @@ -1406,7 +1412,7 @@ public async Task PuGraphEdgeAsync_ShouldThrow_WhenGraphNotFound()
});

Assert.Equal(HttpStatusCode.NotFound, exception.ApiError.Code);
Assert.Equal(1924, exception.ApiError.ErrorNum); // GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, exception.ApiError.ErrorNum);
}

[Fact]
Expand Down Expand Up @@ -1453,7 +1459,7 @@ public async Task PutEdgeDefinitionAsync_ShouldThrow_WhenGraphNameDoesNotExist()
});

Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
Assert.Equal(1924, ex.ApiError.ErrorNum); // GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, ex.ApiError.ErrorNum);
}

[Fact]
Expand Down Expand Up @@ -1632,7 +1638,7 @@ public async Task GetEdgeAsync_ShouldThrow_WhenGraphIsNotFound()
});

Assert.Equal(HttpStatusCode.NotFound, exception.ApiError.Code);
Assert.Equal(1924, exception.ApiError.ErrorNum); // GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, exception.ApiError.ErrorNum);
}

[Fact]
Expand Down Expand Up @@ -1754,7 +1760,7 @@ public async Task PatchEdgeAsync_ShouldThrow_WhenGraphNotFound()
});

Assert.Equal(HttpStatusCode.NotFound, exception.ApiError.Code);
Assert.Equal(1924, exception.ApiError.ErrorNum); // GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, exception.ApiError.ErrorNum);
}

[Fact]
Expand Down Expand Up @@ -1849,7 +1855,7 @@ public async Task PutVertexAsync_ShouldThrow_WhenGraphIsNotFound()

Assert.True(ex.ApiError.Error);
Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
Assert.Equal(1924, ex.ApiError.ErrorNum); // ERROR_GRAPH_NOT_FOUND
Assert.Equal((int)ERROR_GRAPH_NOT_FOUND, ex.ApiError.ErrorNum);
}

[Fact]
Expand All @@ -1869,7 +1875,7 @@ public async Task PutVertexAsync_ShouldThrow_WhenVertexCollectionIsNotFound()
});
Assert.True(ex.ApiError.Error);
Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
Assert.Equal(1203, ex.ApiError.ErrorNum); // ARANGO_DATA_SOURCE_NOT_FOUND
AssertVertexCollectionNotFound(ex.ApiError);
}

[Fact]
Expand Down Expand Up @@ -1897,5 +1903,20 @@ public async Task PutVertexAsync_ShouldThrow_WhenVertexIsNotFound()
Assert.Equal(HttpStatusCode.NotFound, ex.ApiError.Code);
Assert.Equal(1202, ex.ApiError.ErrorNum); // ARANGO_DOCUMENT_NOT_FOUND
}

private void AssertVertexCollectionNotFound(ApiErrorResponse error)
{
bool isVersion312OrLater = _fixture.VersionMajor > 3 ||
(_fixture.VersionMajor == 3 && _fixture.VersionMinor >= 12);

if (isVersion312OrLater)
{
Assert.Equal((int)ERROR_GRAPH_COLLECTION_NOT_PART_OF_THE_GRAPH, error.ErrorNum);
}
else
{
Assert.Equal((int)ERROR_ARANGO_DATA_SOURCE_NOT_FOUND, error.ErrorNum);
}
}
}
}
Loading