Implement a robust mapping merger. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mapping merger enriches a primary mapping with the information given by a secondary mapping. The resulting mapping is then filtered to avoid invalid mappings.
There were some occasions in which tree was null in setDstName. This is fixed by not using tree whenever it is null.
Some classes such as 1InterRecipient were still included in the mapping even though they had an invalid class name. This is now fixed by changing the predicate to accept / filter out a class mapping.
Natlink
reviewed
Nov 2, 2022
There was a problem hiding this comment.
de manière générale:
- sympa le pattern visitor, on en a pas dans le projet, mais c'est cool quand c'est bien utilisé
- On utilise pas de printf dans le projet, mais les loggers de log4j
- les boucles foreach(collection) -> à remplacer par des streams (ce qui se rapproche au mieux du paradigme fonctionnel en java)
Comment on lines
+92
to
+94
| for (String srcName : entry.getValue()) { | ||
| primaryMappingTree.removeClass(srcName); | ||
| } |
There was a problem hiding this comment.
il faudrait une méthode removeAll(Collection) dans MemoryMappingTree pour éviter la complexité en O(n²)
There was a problem hiding this comment.
Je vois pas le O(n²), pour moi c'est du O(n) avec n le nombre de classes dans le .jar obfusqué. Et le removeAll finirai par faire une boucle for aussi non?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapping merger enriches a primary mapping with the information given by a secondary mapping.
The resulting mapping is then filtered to avoid invalid mappings.