Open
Conversation
Signed-off-by: LeeSeolHui <lsh81550@gmail.com>
Signed-off-by: LeeSeolHui <lsh81550@gmail.com>
eugene70
reviewed
Oct 6, 2024
eugene70
left a comment
eugene70
left a comment
There was a problem hiding this comment.
찬영님께 코멘트한 것 처럼 app.go 의 코드를 참고하여 수정해 주시면 NewContextCommand 메소드가 너무 길어지는 것을 방지할 수 있을 것 같습니다.
cmd/argocd/commands/context.go
Outdated
| }, | ||
| } | ||
|
|
||
| // Get context details |
There was a problem hiding this comment.
아래와 같이 Get Command 생성부를 별도의 메소드로 분리하는 것이 좋을 것 같습니다. app.go 참고.
func NewContextGetCommand(clientOpts *argocdclient.ClientOptions) *cobra.Command {
...
}
cmd/argocd/commands/context.go
Outdated
| command.AddCommand(listCommand) | ||
| command.AddCommand(useCommand) | ||
| command.AddCommand(deleteCommand) | ||
| command.AddCommand(getDetailsCommand) |
There was a problem hiding this comment.
app.go 에서처럼 AddCommand의 인자로 Get Command 생성 함수를 호출하는 방식이 좋겠습니다.
command.AddCommand(NewContextGetCommand(clientOpts))
Signed-off-by: LeeSeolHui <lsh81550@gmail.com>
Signed-off-by: LeeSeolHui <lsh81550@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue #12
Checklist: