fix(helm): remove hook annotations #9486
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yann Soubeyrand <[email protected]>
dosubot
bot
added
the
size:XS
|
Hey @yann-soubeyrand, can you share an example to show us how this prevents successful deployment on Pulumi? |
|
@axiomofjoy the Pulumi Helm Chart v4 resource (https://www.pulumi.com/registry/packages/kubernetes/api-docs/helm/v4/chart/) does not support Helm hooks. What I’m wondering is what is the purpose of these hooks? They seem to be useless at first, be maybe I missed something. |
|
My understanding is these hooks are trying to ensure that Postgres starts before the Phoenix container. |
|
Hello @axiomofjoy, I’m not sure these hooks reach their objective: the Phoenix deployment has |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These hooks seem to be useless and prevent successful deployment with certain tools (like Pulumi).