-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Picker with Validation #124
Conversation
size-limit report 📦
|
I think it's more driven by the "inline" layout than anything here because it's the layout of the form that currently gives space for the errors. I think ultimately if errors are going to be shown in tooltips we need to figure out how to show an error indicator without changing the layout since these inputs are extremely small. Datadog shows an error indicator at the top right of the input (not an icon) and puts a tooltip on the entire component. This is probably the least intrusive thing I've seen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think spectrum ultimately doesn't believe that pickers can be in an invalid state - e.g. why would you let someone pick something that's invalid.
Might be worth thinking about what causes pickers to be invalid - ultimately it's another field that causes it to be invalid - is there a way to completely eliminate that flow?
e6c078f
to
31f6ba5
Compare
add validation to picker + dropdown button PR comments
31f6ba5
to
5c4be73
Compare
resolves https://github.com/Arize-ai/arize/issues/21007
Before
After
Up next:
Think through how to show help text in
isQuiet
(should it be within ui-components or passed in through controller) in design reviewScreen.Recording.2023-04-28.at.3.16.36.PM.mov