fteat: layout flex #125
Merged
fteat: layout flex #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mikeldking
commented
May 12, 2023
| @@ -33,6 +33,8 @@ | |||
| "forceConsistentCasingInFileNames": true, | |||
| // `tsdx build` ignores this option, but it is commonly used when type-checking separately with `tsc` | |||
| "noEmit": true, | |||
| // we can explicitly declare `any`, but we don't want to infer `any` | |||
| "noImplicitAny": false, | |||
There was a problem hiding this comment.
this allows us to access the key of an interface without having to cast it as a key. Safe change to make I think
mikeldking
commented
May 13, 2023
| } = props; | ||
| const { styleProps } = useStyleProps(props, viewStyleProps); |
There was a problem hiding this comment.
@JackyxCS this is a semi-breaking change in that the way you declare borders requires a bit more props. I might need help migrating the app with you to use the right props here.
There was a problem hiding this comment.
sounds good view's only used in a couple of places I can help add the req props!
JackyxCS
approved these changes
May 15, 2023
| } = props; | ||
| const { styleProps } = useStyleProps(props, viewStyleProps); |
There was a problem hiding this comment.
sounds good view's only used in a couple of places I can help add the req props!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
Flexprimitive for layout purposes