feat: Add extra to tabs #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JackyxCS
commented
Jun 20, 2023
•
JackyxCS
commented
- adds an extra action(s) option to tabs
- required for cluster summarization:
- referenced: https://ant.design/components/tabs
size-limit report 📦
|
mikeldking
approved these changes
Jun 20, 2023
src/tabs/Tabs.tsx
Outdated
| @@ -33,14 +33,14 @@ const tabListCSS = css` | |||
| --tab-hover-color: ${transparentize(0.2, theme.colors.arizeBlue)}; | |||
| --tab-selected-border-color: ${theme.colors.arizeBlue}; | |||
|
|
|||
| button { | |||
| button[role='tab'] { | |||
There was a problem hiding this comment.
it might be worth figuring out a way to keep a specificity of 1 here. Having a specificity higher makes customization a bit harder
src/tabs/Tabs.tsx
Outdated
| @@ -66,11 +66,17 @@ const tabListCSS = css` | |||
| border-color: var(--tab-selected-border-color); | |||
| } | |||
| } | |||
| .ac-tabs__extra-content { | |||
There was a problem hiding this comment.
this is the extra wrap right? probably worth not naming it content.
ui-components/src/field/FieldLabel.tsx
Line 91 in 3153c3d
src/tabs/Tabs.tsx
Outdated
| @@ -154,6 +168,7 @@ export function Tabs({ | |||
| </button> | |||
| ); | |||
| })} | |||
| {extra && <div className="ac-tabs__extra-content">{extra}</div>} | |||
There was a problem hiding this comment.
Suggested change
| {extra && <div className="ac-tabs__extra-content">{extra}</div>} | |
| {extra && <div className="ac-tabs__extra">{extra}</div>} |
src/tabs/Tabs.tsx
Outdated
Comment on lines
70
to
73
| display: flex; | ||
| align-items: center; | ||
| justify-content: flex-end; | ||
| flex-grow: 1; |
There was a problem hiding this comment.
this means the extra takes up the entire width on the right-hand side - I think it's probably worth just having the content aligned left and let it form it's own layout rather than forcing flex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.