Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use 100vh for wrapper height instead of useViewportSize #144

Merged
merged 3 commits into from
Jul 31, 2023
Merged

fix: Use 100vh for wrapper height instead of useViewportSize #144

merged 3 commits into from
Jul 31, 2023

Conversation

JackyxCS
Copy link
Contributor

  • in arize web, pinching on a trackpad to zoom in was altering the viewport height while scaling the content at the location of the mouse, which causes behavior noticed here:
Screen.Recording.2023-07-28.at.5.18.20.PM.mov
  • surprisingly, this was ok in the slideover story because the viewport height wasn't being altered by the pinching (notice that the height remains 908px regardless of pinching)
Screen.Recording.2023-07-28.at.5.31.10.PM.mov
  • not certain of why this difference is but changing to use 100vh would fix this

@github-actions
Copy link

github-actions bot commented Jul 28, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@JackyxCS
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link

github-actions bot commented Jul 28, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/components.cjs.production.min.js 162.53 KB (-0.03% 🔽)
dist/components.esm.js 111.67 KB (-0.15% 🔽)

mikeldking
mikeldking reviewed Jul 31, 2023
View reviewed changes
stories/SlideOver.stories.tsx Outdated
@@ -74,7 +74,7 @@ const content = (
</Card>
<Card title="Section 9">
<Text>hello</Text>
</Card>
</Card> */}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restore

@JackyxCS JackyxCS merged commit e2def9a into main Jul 31, 2023
9 of 10 checks passed
@JackyxCS JackyxCS deleted the set-modal-height-to-100-vh branch July 31, 2023 20:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikeldking mikeldking mikeldking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JackyxCS @mikeldking