add more custom icons for model side nav #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mikeldking
reviewed
Nov 27, 2023
src/icon/Icons.tsx
Outdated
| width="2.5" | ||
| height="3.64864" | ||
| rx="1.25" | ||
| fill="white" |
There was a problem hiding this comment.
We need to delete all these "white" hard codings. If you run the the storybook the colors will probably not rotate.
There was a problem hiding this comment.
took a minute but removed all the fills! had to regenerate some of these icons since figma automatically includes it on export
mikeldking
approved these changes
Nov 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing custom icons to ui-library for new model sidenav.
Dark mode
Light mode