feat: allow overriding the selectedTab on Tabs component #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mikeldking
reviewed
Jan 22, 2024
src/tabs/Tabs.tsx
Outdated
| /** | ||
| * If specified, the index of the selected tab is controlled by the parent component rather than the internal state. | ||
| */ | ||
| selectedTabIndex?: number; |
There was a problem hiding this comment.
Let's switch this to be index as that's the most aria compliant naming: https://github.com/reach/reach-ui/blob/43f450db7bcb25a743121fe31355f2294065a049/packages/tabs/src/reach-tabs.tsx#L82
mikeldking
reviewed
Jan 22, 2024
mikeldking
reviewed
Jan 22, 2024
src/tabs/Tabs.tsx
Outdated
Comment on lines
146
to
147
| const selectedIndex = | ||
| typeof selectedTabIndex == "number" ? selectedTabIndex : selectedStateIndex; |
There was a problem hiding this comment.
Not blocking but you could encapsulate all this in a hook like useControlledState
mikeldking
reviewed
Jan 22, 2024
src/tabs/Tabs.tsx
Outdated
| const [selectedIndex, setSelectedIndex] = useControlledState( | ||
| index, | ||
| defaultValue, | ||
| () => {} |
There was a problem hiding this comment.
I think you can simplify this even further
export function useControlledState<T, C = T>(value: Exclude<T, undefined>, defaultValue: Exclude<T, undefined> | undefined, onChange?: (v: C, ...args: any[]) => void): [T, (value: T) => void];
Suggested change
| () => {} | |
| onChange |
There was a problem hiding this comment.
This should allow you to fully remove the explicit call to onChange below
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings to parity with our current
Tabscomponent in the arizeweb library which lets you control the selectedTab. Without this, you can't change the selectedTab outside of just clicking the tab itself, example as a callback on a button.https://github.com/Arize-ai/arize/blob/main/arizeweb/src/app/components/shared/Tabs.tsx#L86-L88