refactor: evm ecdsa adjustments #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stem/php-crypto into refactor/evm-ecsdas-adjustments
ItsANameToo
changed the title
alfonsobries
changed the title
ItsANameToo
requested changes
Nov 12, 2024
| 'gasPrice' => '5', | ||
| 'nonce' => '1', | ||
| 'network' => Network::get()->pubKeyHash(), | ||
| 'gasLimit' => 1_000_000, |
There was a problem hiding this comment.
can we set default gas limits for the supported transaction types? e.g.:
- transfer: 21000
- validator registration: 500000
- validator resignation: 150000
- vote: 200000
- unvote: 200000
- default: 1000000
I didn't see them being overwritten in the code in the builders, but maybe I overlooked something
There was a problem hiding this comment.
@ItsANameToo Deleted all the code related to fees, it's not actually being used anywhere
|
@ItsANameToo ready |
|
im also removing the Fee section on the docs here https://github.com/ArdentHQ/docs-poc-protocol/pull/74 |
ItsANameToo
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/86dv4y6kn
Checklist