Catch useless ?? null and ?? undefined
#13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the noUnnecessaryCondition rule to detect useless nullish coalescing patterns where the right-hand side value is already included in the left-hand side type (e.g., x ?? null when x is string | null).
Key Changes:
- Added detection for redundant
?? nullwhen the left type includesnull - Added detection for redundant
?? undefinedwhen the left type includesundefined - Added auto-fix suggestions to remove unnecessary nullish coalescing
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/rules/noUnnecessaryCondition/noUnnecessaryCondition.ts | Added new error messages and logic to detect useless ?? null and ?? undefined patterns, refactored checkNodeForNullish to analyze both sides of the expression |
| src/rules/noUnnecessaryCondition/noUnnecessaryCondition.test.ts | Added test cases for the new functionality and updated existing test assertions with corrected column numbers and new suggestion outputs |
| CHANGELOG.md | Documented the new feature in the unreleased section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements typescript-eslint/typescript-eslint#8079 that I just had today