Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix token_based_document_to_text_based / text_based_document_to_token_based for dependent predicted annotations #135

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Oct 21, 2024

...by constructing annotation lookup table also from predictions. This fixes a regression introduced in #126.

Note: The error occurred when any of the span layers have a dependent layer (e.g. relations) which have predictions. The predictions of these dependent layers are added, but the mapping (old ids to new annotations) was not correctly converted.

@ArneBinder ArneBinder added the bug Something isn't working label Oct 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.61%. Comparing base (86146b6) to head (a3ebe6c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files          61       61           
  Lines        5107     5107           
=======================================
  Hits         4883     4883           
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArneBinder ArneBinder merged commit 1739476 into main Oct 21, 2024
2 checks passed
@ArneBinder ArneBinder deleted the fix_text_based_document_to_token_based branch October 21, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants