-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add argument_type_whitelist
parameter to RETextClassificationWithIndicesTaskModule
#152
add argument_type_whitelist
parameter to RETextClassificationWithIndicesTaskModule
#152
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 95.49% 95.51% +0.01%
==========================================
Files 61 61
Lines 5195 5212 +17
==========================================
+ Hits 4961 4978 +17
Misses 234 234 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main code looks good, but please simplify the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still hard to verify, see below
Add extra test to cover ValueError
Add assertions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
argument_type_whitelist
parameter
argument_type_whitelist
parameterargument_type_whitelist
parameter to RETextClassificationWithIndicesTaskModule
Adds
argument_type_whitelist: List[List[str]]
parameter used by_add_candidate_relations()
.This allows adding candidates only of pre-defined argument type pairs.
E.g. when
argument_type_whitelist=[['ORG','PER']]
only relations with head.label='ORG' and tail.label='PER' will be added.TODO: