Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleGenerativeModel: improve base model setup #153

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Feb 5, 2025

TODO:

  • [ ] implement from_config path considering is_from_pretrained as implemented here EDIT: no, some models (e.g. bartAsPointerNetwork) do not seem to have from_config()
  • increase test coverage
  • add PR description

@ArneBinder ArneBinder added the enhancement New feature or request label Feb 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.50%. Comparing base (afcf7d4) to head (6c6a835).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   95.49%   95.50%           
=======================================
  Files          61       61           
  Lines        5195     5203    +8     
=======================================
+ Hits         4961     4969    +8     
  Misses        234      234           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants