fix annotations that are reported as missing after tokenization #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cuments are returned
ArneBinder
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 96.28% 96.33% +0.05%
==========================================
Files 23 23
Lines 1694 1718 +24
==========================================
+ Hits 1631 1655 +24
Misses 63 63 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes which annotations are reported as missing after tokenization. When
tokenize_document()returns multiple documents because of partitioning or windowing, the annotations are distributed on the respective result documents. This means, that each result document may lack some annotations but these may be still covered by other result docs. With this PR, we only report the annotations as missing that are not added to any of the result documents (e.g. spans because of alignment errors or relations because their arguments are in different result documents).This requires: ArneBinder/pytorch-ie#390 (i.e.
pytorch-ie>=0.29.4)