Skip to content

add metrics.ConfusionMatrix#179

Merged
ArneBinder merged 6 commits intomainfrom
metrics/confusion_matrix
Apr 12, 2025
Merged

add metrics.ConfusionMatrix#179
ArneBinder merged 6 commits intomainfrom
metrics/confusion_matrix

Conversation

@ArneBinder
Copy link
Copy Markdown
Owner

@ArneBinder ArneBinder commented Apr 8, 2025

from pytorch-ie

context: ArneBinder/pie-core#17 and #172

EDIT: see #188 for a bug fix for this metric.

@ArneBinder ArneBinder added the enhancement New feature or request label Apr 8, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.88%. Comparing base (e0c089e) to head (501e1f6).
⚠️ Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   95.82%   95.88%   +0.05%     
==========================================
  Files          67       68       +1     
  Lines        5968     6047      +79     
==========================================
+ Hits         5719     5798      +79     
  Misses        249      249              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tests/metrics/test_confusion_matrix.py Outdated
Comment thread tests/metrics/test_confusion_matrix.py Outdated
@redspottedbittern
Copy link
Copy Markdown
Collaborator

So, I had some time and added tests already. It is not yet fully done, since I need some feedback. Generally, I added the tests strictly along the lines of Codecov, i.e. for the lines Codecov says tests are missing. So I didn't think about a higher concept

@redspottedbittern redspottedbittern self-assigned this Apr 11, 2025
@redspottedbittern redspottedbittern marked this pull request as ready for review April 12, 2025 11:07
@ArneBinder ArneBinder merged commit 91b5a20 into main Apr 12, 2025
2 checks passed
@ArneBinder ArneBinder deleted the metrics/confusion_matrix branch April 12, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants