New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#204] Fix UDF nullability rules #205

Merged

mwylde merged 1 commit into master from udf_nullability_fix

Jul 17, 2023

Member

mwylde commented Jul 15, 2023

This fixes #204 by correctly implementing the nullability logic for UDFs. The correct logic is that a UDF return type is nullable if either

It's defined with an Optional return type, or
It has any non-optional parameters (in the Rust function) applied with nullable arguments (in SQL)

Previously, the second condition was implemented incorrectly, as "any optional parameters applied with non-nullable arguments).


          Fix UDF nullability rules

512d218

mwylde requested a review from jacksonrnewhouse

July 15, 2023 20:06

jacksonrnewhouse approved these changes

View reviewed changes

mwylde merged commit 1ebb58d into master

mwylde deleted the udf_nullability_fix branch

July 17, 2023 18:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet