[PORT] ZAS, Explosive Decompression [MDB IGNORE] by RimiNosha · Pull Request #531 · Artea-Station/Artea-Station-Server

RimiNosha · 2024-01-14T15:41:34Z

About The Pull Request

Stolen from DD:

Anyways, see title, I'm posting this early cause there's harddels that I need to track down, and I don't have the patience to leave a server open in the background for possibly around an hour.

Near future TODOs:

Add a new type of generator, potentially the RBMK.
Fix up and readd bay's version of the R-UST.
Add a new pipeline for heat waste to space radiators. This should make heat management more of an active thing rather than making it yet another "add more power lol" thing.
- Yeah, there's gonna have to be a doc on this so I get it right 😔
Add more gasses, potentially look into adding new ways of making gasses.
Implement evil plasma mechanics properly. They're disabled right now to avoid ballooning my fucking changelog size and the amount of mechanics added in one PR.

How Does This Help Gameplay?

Space is dangerous as fuck now, and you shouldn't be careless when changing the station.

How Does This Help Roleplay?

"Hey, are you gonna patch that hole?"
"Nah, SSair is running at 2500% tidi, we've hours before it becomes a problem. Just stick a space heater inside for the lizards."

Proof of Testing

In your wildest dreams. This will be buggy while I iron out all the issues found in playtests.

Changelog

🆑 Kapu (original), RimiNosha (port)
add: ZAS, a blazing fast, if somewhat simplified atmos system.
del: LINDA (our old, slow as balls atmos system)
add: Explosive decompression, which is, as the name suggests, dangerous.
balance: Space is no longer magically ultra-cold for pipes.
qol: Air alarms now have inbuilt heaters. They're nowhere near as powerful as space heaters, though!
del: Aninoblium, Hypernoblium, Freon, Halon, Healium, Pluoxium, Nitrium, BZ, Masma, Proto Nitrate, Zauker.
spellcheck: Water Vapour > Steam
add: Alium, a fucked gas that will have random attributes each round.
add: Deuterium, which burns ~20% hotter than hydrogen.
add: Argon, Neon, Krypton, Xenon, Boron, which are all noble gases with differing behaviours.
add: Methane, which is stinky, as is the replacement for Miasma.
add: Ammonia, Chlorine, Methyl Bromide, Nitrogen Dioxide, all of which are potent toxins.
add: Nitric Oxide, Sulfur Dioxide.
add: Walls can now melt from high temperatures.
del: Openturf fusion. Replacement coming in the near future.
del: HFR. Not like many folk knew the thing even existed, nevermind how it works.
del: Pressure resistance. Anything not anchored will be moved by pressure effects.
/:cl:

* Initial commit * PAIN AND AGONY * Under 1000 errors * Checkpoint! * Gonna pull the trigger soon * Co-authored-by: Gallyus <francinum@users.noreply.github.com> * adds immutable mixtures * !!!/SIMULATED/ REMOVAL!!! * ITS TIME * ZAS HELL * it compiles * atmostest * cummies * AMONG US * SSzas refactor + initial gas stuff * Space wind tweaks * Initial Gas Mixture fixes, Admin Debug Verbs * :screm: * Firedoors should no longer cause zone rebuilds * Misc fixes * Updates c_airblock to check QDELETED * Fire stuff - spreading is scuffed * FIRE WOOORKSSSS * Returns ZAS wait to 2 seconds (sadness) * Updates SSzas and Fire * Partial revert of MC changes * SSairmachines * Some fixes. Atmos Sensitive still needs signals * Atmos Alarms now work properly & trigger firedoors * Attempts to make scrubbers work right, failed * Updates SSzas * Scrubbers and the beginning of atmos sensitivity removal * fixes the overlay code w/ placeholders * SSairmachines now recovers during MC failure * BURN BABY BURN. And glass cracking sounds * temp removals * All linters fixed * grumble * grumble 2 * fuck * FUCK * Globals * wohops * MINTEST: Atmos Equipment Addition * Further map updates, add maps.txt def * Typo + fixes? passive gates * Fixes passive gate for real and fixes a canister bug * Hahaha im a dumbass. * FUCK * Moar gases, gaseous reagents, and handling. * Updates fire code to be more functional * Removes atmos sensitivity * LAVALAND TEST + DEBUG IMPROVEMENT * changes for test * the station is no longer covered in shrek cum * lung runtime fix maybe * Improves airflow behavior significantly * Dense objects can now step into non-dense objects during Airflow * Micro opt * makes all gas mixture procs camelcase (I will regret this later) * Clean up, fixes reconcile_air(), recode copyFrom() * Fixes critical math errors. * More equipment to test. * Fixes gas anal. * Fix atmos filters. Quantize gas during filtering * Slightly better fix * Fixes an error in verb permission. * TYPO * Bring back pre-init messages * Fix some bugs * HAHAHAHAHAHHA WHOOPS * Fixes kilo. The great unspace-ening * Third times the charm * Fixes atmos resin. * Fixes the portable air pump. I hope. * Grammar * stupid language * Makes some gases purchasable. Oops. * Purchaseable air canisters. I hope. * Fixes roundstart plasma * Canisters have the correct heat resistence * Fixes? directional windows blocking atmos due to being constructed on unsimulated turfs * Fixes N2O not knocking you the fuck out * Fixes atmos consoles and n2o overlays * Rewrites vent pumps * Tweaks, mainly to airflow * Hibernation, filters, optimizations. * Disables ZASDBG and adds last process * Unfucks varedits, optimizes updateValues() by making it a macro * lets see if this works i guess * Unit Test BS * linter appeasement * TGM format * Whoops * brings back precision clean up * Pushing this so dreammaker doesnt eat my ass * more R-UST work * R-UST progress * Mo shit * more fuel rod stuff * softdel my rod * grumble * This is probably fine. * Alot of progress. Still fighting the selfmerge bug * ZAS READABILITY UPDATE Adds a ton of comments to ZAS procs, renames some, and greatly improves ZAS debugging tools. * REALLY hacky fix to shuttle movement * Compile stuff + misleading proc name change * multizas testing map * Enables MultiZAS * Try to fix world bounds issue with ZAS * Runtimes fix * Fixes a hilarious oversight * CI * please * fix icebox * Linter pass attempt 1 * more unused stuff cleanup * gas id update * more unused stuff * mooooore shiit * are you fucking kidding me * please dont make me force push a reset * hard del fix + transfer moles debugging * typo * try to fix reactor hard del * Fix some bugs. fuel_objs no longer leave refs * I Am An Idiot (fire compile fix) * Fixes mapping error causing a bad init * docs zas compile options * Disables SSairflow during unit tests. * Fixes a critical bug, some more bugs, and comments * Disables ZASDBG * more comments + another attempt to find this bug * fixes an erroneous return value * Prevents air from moving up/down in hyperspace * Please don't break anything. Adds the Supermatter * Hibernating scrubbers now appear as off * Whoops. Forgot to stage the N2 tank changes. * fix maps * re-adds SM monitor * Fixes scrubber runtime * Hopefully fixes magboots * Fixes * EXPERIMENTAL: Smart Vents/Pipes * Airflow tweaks and improvements * TTVs should now function more * writing * Fixes fire runtime * optimizations, gasgas bad * Liquid plasma now has the proper atmos temp * fixes the implosion thingy * Fixes is_safe_turf * fixes is_safe_turf for real * misc tweaks * vent pump examine * HOW DID THIS FIX IT? WHAT? THE FUCK ????? * Fuck it. This is fine. * oops * please dont break anything thx * disables debug * Remove multiline comments in the DME * runtime fix * Tries to fix knockdown, and buffs extinguisher cooling * help me debug pls * "air" is now a valid label for canisers * filter changes * Fixes pluox and tritium :) * air alarms now have the full gas list + reordered * Re-orders common gas list * Makes deuterium isotope 2 * vent and scrubber controls now reset hibernation * Fixes portable scrubbers, changes to air alarms * Explosion pass * Fixes * Fixes atmozphere program. fuck js * Reworks some lists n' things * removes redundant global list * Back-to-basics firelocks, pt1 * fire/air alarm + firedoor refactor. Fuck me harder * IM A DUMBASS IM A DUMBASS IM A DUMBASS * ashlizard lungs * fix compile * Adds airalarm firealerts and thermostats * fix some runtimes * oops * I CLICKED STAGE ALL FOR FUCK SAKE VSC * Fix fire * removes leftover testing artifact * for real this time * Removes unused files * Fixes nitrodioxide label * fixes methyl bromide label * micro opts * Tramstation should no longer freeze the server * Removes minimum zone size * Linterinos * linterinos for real * Reverts zone size change, makes other tweaks * Tries to fix the phantom rest bug * airflow fix * Clean up + code ownership * fix mdb i think Co-authored-by: Francinum <5572280+francinum@users.noreply.github.com>

…yond changes

* Fixes a gamebreaking zas init bug * fix Reboot * disable ZASDBG * remove the other debug artifact # Conflicts: # code/game/machinery/doors/firedoor.dm

* Fixes the contaminated setting * oops! * bump ambience * optimizes fire signals * fix ship ambi # Conflicts: # code/game/area/areas.dm # code/modules/power/lighting/light.dm

* Vacuums now all act like space for heat exchange * Massive oversight * Fix windows * fixes # Conflicts: # code/game/machinery/doors/airlock.dm # code/game/objects/effects/effect_system/effects_foam.dm # code/game/objects/structures/false_walls.dm # code/game/objects/structures/window.dm

…improvements. FEATURE CREEP FEATURE CREEP FEATURE CREEP FEATURE CREEP FEATURE CREEP FEATURE CREEP FEATURE CREEP (Artea-Station#5) * ZAS: At The Speed of Light * fix runtimes/issues * more fixes * re-add atmos exposure, subsystem edition * adjustments and disable multizas * fixes and opts * house cleaning * perf * Slice zone tick cost in half * Fix diseases and Create Area # Conflicts: # code/__DEFINES/atmospherics/atmos_canpass.dm # code/__DEFINES/atmospherics/atmos_helpers.dm # code/__DEFINES/subsystems.dm # code/_compile_options.dm # code/controllers/subsystem/zas.dm # code/datums/atmosphere/_atmosphere.dm # code/datums/atmosphere/planetary.dm # code/datums/elements/atmos_requirements.dm # code/datums/elements/smell.dm # code/datums/status_effects/debuffs/fire_stacks.dm # code/game/machinery/computer/atmos_computers/_air_sensor.dm # code/game/objects/effects/effect_system/effects_foam.dm # code/modules/atmospherics/ZAS/Expose.dm # code/modules/atmospherics/ZAS/Fire.dm # code/modules/atmospherics/ZAS/Turf.dm # code/modules/atmospherics/ZAS/XGM/xgm_gas_mixture.dm # code/modules/atmospherics/ZAS/Zone.dm # code/modules/atmospherics/machinery/airalarm.dm # code/modules/atmospherics/machinery/components/unary_devices/vent_scrubber.dm # code/modules/atmospherics/machinery/portable/pump.dm # code/modules/atmospherics/machinery/portable/scrubber.dm # code/modules/cargo/bounties/engineering.dm # code/modules/credits_roll/episode_name.dm # code/modules/mob/living/carbon/alien/humanoid/humanoid.dm # code/modules/mob/living/carbon/human/human_helpers.dm # code/modules/modular_computers/file_system/programs/atmosscan.dm # code/modules/power/supermatter/supermatter_process.dm # code/modules/reagents/chemistry/reagents/food_reagents.dm # code/modules/reagents/chemistry/reagents/pyrotechnic_reagents.dm # code/modules/research/server.dm # tgstation.dme

…oh_god # Conflicts: # code/game/turfs/closed/_closed.dm

RimiNosha · 2024-01-21T19:03:20Z

Turbines confirmed working with relatively balanced values. May need adjustments if power is found to be too much, or too little.

ReturnToZender · 2024-01-25T18:48:14Z

Kicking absolute ass Rimi, keep up the good work 👍

RimiNosha · 2024-01-25T19:03:14Z

Tempted to YOLO merge this so I can work on the near-future TODO stuff immediately.

…oh_god # Conflicts: # code/__DEFINES/atmospherics/atmos_mob_interaction.dm

RimiNosha · 2024-01-25T19:45:27Z

Kicking absolute ass Rimi, keep up the good work 👍

Downstream Artea 😛

RimiNosha · 2024-01-25T20:06:41Z

Fuck it, YOLO

RimiNosha and others added 30 commits January 10, 2024 22:39

Oops

3a6d559

Yeet

7a7c842

Yoink

28ae166

50 compile errors down, 507 more to go.

6a16d00

455 left

8789d45

~425 left

116be78

Firealarm stuff, 406 to go

d1ed8c5

301 left

97fe856

Oh my fucking god stop setting atmos mixes on init, 264 left

d79e397

161 left

eb325dc

Rest in piss hypernob

f6ec8b8

101 left

69142d5

:)

4473061

58 left

4f9d1a4

48 left

2d229aa

SM my beloathed, 41 left

a7ddece

Everything but planet atmos has been "fixed"

9ccf7e1

It now compiles, aside from centcom. I need to updatepaths this

368558f

Regex my beloved

634ce37

Fix

d0c12c9

You need to fix stamina

f436b0b

FUCK YOU, YOU BROKE EVERYTHING

390f9fa

Do it in maybe a more copy-paste way but in a way that won't die to b…

fc4f3aa

…yond changes

Fixes a gamebreaking zas init bug (Artea-Station#34)

7b08188

* Fixes a gamebreaking zas init bug * fix Reboot * disable ZASDBG * remove the other debug artifact # Conflicts: # code/game/machinery/doors/firedoor.dm

Fixes the contaminated setting on air alarms (Artea-Station#77)

87baba0

* Fixes the contaminated setting * oops! * bump ambience * optimizes fire signals * fix ship ambi # Conflicts: # code/game/area/areas.dm # code/modules/power/lighting/light.dm

fix atmos spawn air (Artea-Station#179)

7d43e52

Oops

893810a

RimiNosha added 5 commits January 17, 2024 17:54

Yeet ded code

cf0bb96

Ded code

c7d27ba

I have the better planet atmos code now

c7b0864

This isn't needed yet

2a9fce1

Add a bit of random

73c3e82

RimiNosha marked this pull request as ready for review January 18, 2024 19:53

RimiNosha changed the title ~~[PORT] ZAS, Plasma Contamination, Explosive Decompression [MDB IGNORE]~~ [PORT] ZAS, Explosive Decompression [MDB IGNORE] Jan 18, 2024

Fix a couple of issues

1b26060

github-actions bot added the Merge Conflict Uh oh, a maint merged a PR that edits the same stuff as yours! label Jan 21, 2024

Merge commit '3f692241df9452de764ff592976ff12760568ec5' into oh_fuck_…

56b42d5

…oh_god # Conflicts: # code/game/turfs/closed/_closed.dm

RimiNosha removed the Merge Conflict Uh oh, a maint merged a PR that edits the same stuff as yours! label Jan 21, 2024

RimiNosha added 2 commits January 22, 2024 15:15

Yeet ded code, bring back methane interactions

d101a48

Literally always 0, fuck off

b5b10d6

This was referenced Jan 24, 2024

Air alarm offset is wonky #536

Closed

Critical mapping error on Bearcat #537

Closed

Crowbars straight up dont work on firelocks #538

Closed

RimiNosha added 2 commits January 25, 2024 18:49

Fix firelock crowbarring

1e1087b

Fix airalarm offsets

ab1c0ab

github-actions bot added the Merge Conflict Uh oh, a maint merged a PR that edits the same stuff as yours! label Jan 25, 2024

RimiNosha added 2 commits January 25, 2024 19:33

Merge commit 'ddcaa092445f607224845739ce7204f10b8158de' into oh_fuck_…

a74fb97

…oh_god # Conflicts: # code/__DEFINES/atmospherics/atmos_mob_interaction.dm

Second part of above. Suffer.

d877a7e

RimiNosha removed the Merge Conflict Uh oh, a maint merged a PR that edits the same stuff as yours! label Jan 25, 2024

RimiNosha merged commit cbc8f44 into Artea-Station:master Jan 25, 2024

RimiNosha deleted the oh_fuck_oh_god branch January 25, 2024 20:06

Artea-Station-Bot added a commit that referenced this pull request Jan 25, 2024

Automatic changelog for PR #531 [ci skip]

54ab2d5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PORT] ZAS, Explosive Decompression [MDB IGNORE]#531

[PORT] ZAS, Explosive Decompression [MDB IGNORE]#531
RimiNosha merged 86 commits intoArtea-Station:masterfrom
RimiNosha:oh_fuck_oh_god

RimiNosha commented Jan 14, 2024 •

edited

Loading

Uh oh!

RimiNosha commented Jan 21, 2024

Uh oh!

ReturnToZender commented Jan 25, 2024

Uh oh!

RimiNosha commented Jan 25, 2024

Uh oh!

RimiNosha commented Jan 25, 2024

Uh oh!

RimiNosha commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

RimiNosha commented Jan 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

About The Pull Request

How Does This Help Gameplay?

How Does This Help Roleplay?

Proof of Testing

Changelog

Uh oh!

RimiNosha commented Jan 21, 2024

Uh oh!

ReturnToZender commented Jan 25, 2024

Uh oh!

RimiNosha commented Jan 25, 2024

Uh oh!

RimiNosha commented Jan 25, 2024

Uh oh!

RimiNosha commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

RimiNosha commented Jan 14, 2024 •

edited

Loading