Merged
Conversation
- get insight into reason for flagging observation as suspect - modify corrections to be dataframe with correction codes, series values and comparison value. - keep previous nan-based corrections working
Add option to get more information about corrections
martinvonk
approved these changes
Jul 24, 2024
Collaborator
martinvonk
left a comment
martinvonk
left a comment
There was a problem hiding this comment.
I'm not qualified to check this but the code looks clean and nice so 👍
martinvonk
approved these changes
Aug 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The biggest change is that there are now two options for corrections:
Furthermore, this PR contains lots of improvements to the code and documentation, some bugfixes to error detection rules, and better testing, formatting etc.