Skip to content

Conversation

nbusser
Copy link

@nbusser nbusser commented Sep 17, 2025

Related issue

#1108

Description

Merge() was previously only supporting Elements as a Element container.
This PR adds specialization for:

  • all the containers that matches the concept std::ranges::range
  • std::queue
  • std::stack

Interrogation

I did not find a clear reference about the C++ standard that FTXUI claims to support.

@ArthurSonzogni Is it ok to use C++20 concepts here, or should FTXUI be compatible with older C++ standards? In that case I will change the PR content accordingly.

@nbusser nbusser force-pushed the issue-1108/merge-specializations branch from 0bf15db to c6538d7 Compare September 17, 2025 02:36
@ArthurSonzogni
Copy link
Owner

@ArthurSonzogni Is it ok to use C++20 concepts here, or should FTXUI be compatible with older C++ standards? In that case I will change the PR content accordingly.

Yes, I am not going to drop C++17 users soon. Could you please wrap the C++20 parts behind:

#if __cplusplus >= 202002L
...
#endif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants