fix: resolve item amount corruption during trade completion#41
Open
rugiaDev wants to merge 1 commit intoArtillex-Studios:masterfrom
Open
fix: resolve item amount corruption during trade completion#41rugiaDev wants to merge 1 commit intoArtillex-Studios:masterfrom
rugiaDev wants to merge 1 commit intoArtillex-Studios:masterfrom
Conversation
- TradeGui.getItems(): return cloned ItemStacks instead of direct inventory references - Trade.addOrDrop(): pre-clone items before Scheduler deferred execution to prevent timing issues - TradePlayer.getEmptySlots(): count partial stack slots as available to fix checkFull misbehavior During complete(), closeInventory() called by end() and the deferred Scheduler execution created a timing window where ItemStack amounts were mutated before being given to players
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
During
complete(),end()callscloseInventory()which creates a timing windowwhere ItemStack references returned by
getItems()were mutated beforeaddOrDrop()'s deferred Scheduler execution, resulting in incorrect item amountsbeing given to players.
Changes
TradeGui.getItems(): return cloned ItemStacks instead of direct inventory referencesTrade.addOrDrop(): pre-clone items before Scheduler deferred execution to prevent timing issuesTradePlayer.getEmptySlots(): count partial stack slots as available to fix checkFull misbehavior