Refactor(Error): Errors names

Artur-Poffo · Jan 29, 2024 · 38c7deb · 38c7deb
1 parent 3e71424
commit 38c7deb
Show file tree

Hide file tree

Showing 10 changed files with 23 additions and 23 deletions.
diff --git a/src/domain/course-management/application/use-cases/add-class-to-module.spec.ts b/src/domain/course-management/application/use-cases/add-class-to-module.spec.ts
@@ -8,8 +8,8 @@ import { InMemoryCoursesRepository } from '../../../../../test/repositories/in-m
 import { InMemoryInstructorRepository } from './../../../../../test/repositories/in-memory-instructors-repository'
 import { InMemoryModulesRepository } from './../../../../../test/repositories/in-memory-modules-repository'
 import { AddClassToModuleUseCase } from './add-class-to-module'
-import { ClassAlreadyExistsInThisModule } from './errors/class-already-exists-in-this-module'
-import { ClassNumberIsAlreadyInUse } from './errors/class-number-is-already-in-use'
+import { ClassAlreadyExistsInThisModuleError } from './errors/class-already-exists-in-this-module-error'
+import { ClassNumberIsAlreadyInUseError } from './errors/class-number-is-already-in-use-error'
 
 let inMemoryModulesRepository: InMemoryModulesRepository
 let inMemoryCoursesRepository: InMemoryCoursesRepository
@@ -143,7 +143,7 @@ describe('Add class to a module use case', () => {
     })
 
     expect(result.isLeft()).toBe(true)
-    expect(result.value).toBeInstanceOf(ClassAlreadyExistsInThisModule)
+    expect(result.value).toBeInstanceOf(ClassAlreadyExistsInThisModuleError)
   })
 
   it('should not be able to add a class to a module in same number/position twice', async () => {
@@ -180,6 +180,6 @@ describe('Add class to a module use case', () => {
     })
 
     expect(result.isLeft()).toBe(true)
-    expect(result.value).toBeInstanceOf(ClassNumberIsAlreadyInUse)
+    expect(result.value).toBeInstanceOf(ClassNumberIsAlreadyInUseError)
   })
 })
diff --git a/src/domain/course-management/application/use-cases/add-class-to-module.ts b/src/domain/course-management/application/use-cases/add-class-to-module.ts
@@ -7,8 +7,8 @@ import { Class } from '../../enterprise/entities/class'
 import { type ClassesRepository } from '../repositories/classes-repository'
 import { type CoursesRepository } from '../repositories/courses-repository'
 import { type ModulesRepository } from '../repositories/modules-repository'
-import { ClassAlreadyExistsInThisModule } from './errors/class-already-exists-in-this-module'
-import { ClassNumberIsAlreadyInUse } from './errors/class-number-is-already-in-use'
+import { ClassAlreadyExistsInThisModuleError } from './errors/class-already-exists-in-this-module-error'
+import { ClassNumberIsAlreadyInUseError } from './errors/class-number-is-already-in-use-error'
 
 interface AddClassToModuleUseCaseRequest {
   name: string
@@ -21,7 +21,7 @@ interface AddClassToModuleUseCaseRequest {
 }
 
 type AddClassToModuleUseCaseResponse = Either<
-ResourceNotFoundError | NotAllowedError | ClassAlreadyExistsInThisModule | ClassNumberIsAlreadyInUse,
+ResourceNotFoundError | NotAllowedError | ClassAlreadyExistsInThisModuleError | ClassNumberIsAlreadyInUseError,
 {
   class: Class
 }
@@ -65,13 +65,13 @@ export class AddClassToModuleUseCase implements UseCase<AddClassToModuleUseCaseR
     const classWithSameNameInSameModule = classesInThisModule.find(classToCompare => classToCompare.name === name)
 
     if (classWithSameNameInSameModule) {
-      return left(new ClassAlreadyExistsInThisModule(moduleId))
+      return left(new ClassAlreadyExistsInThisModuleError(moduleId))
     }
 
     const classWithSamePositionInThisModule = classesInThisModule.find(classToCompare => classToCompare.classNumber === classNumber)
 
     if (classWithSamePositionInThisModule) {
-      return left(new ClassNumberIsAlreadyInUse(classNumber))
+      return left(new ClassNumberIsAlreadyInUseError(classNumber))
     }
 
     const classToAdd = Class.create({

diff --git a/...rs/class-already-exists-in-this-module.ts → ...ss-already-exists-in-this-module-error.ts b/...rs/class-already-exists-in-this-module.ts → ...ss-already-exists-in-this-module-error.ts
@@ -1,6 +1,6 @@
 import { type UseCaseError } from '@/core/errors/use-case-error'
 
-export class ClassAlreadyExistsInThisModule extends Error implements UseCaseError {
+export class ClassAlreadyExistsInThisModuleError extends Error implements UseCaseError {
   constructor(moduleId: string) {
     super(`Class already exists in this module: module ID ${moduleId}.`)
   }

diff --git a/.../errors/class-number-is-already-in-use.ts → ...s/class-number-is-already-in-use-error.ts b/.../errors/class-number-is-already-in-use.ts → ...s/class-number-is-already-in-use-error.ts
@@ -1,6 +1,6 @@
 import { type UseCaseError } from '@/core/errors/use-case-error'
 
-export class ClassNumberIsAlreadyInUse extends Error implements UseCaseError {
+export class ClassNumberIsAlreadyInUseError extends Error implements UseCaseError {
   constructor(classPosition: number) {
     super(`Class position ${classPosition} is already in use`)
   }

diff --git a/.../course-already-exists-in-this-account.ts → ...e-already-exists-in-this-account-error.ts b/.../course-already-exists-in-this-account.ts → ...e-already-exists-in-this-account-error.ts
@@ -1,6 +1,6 @@
 import { type UseCaseError } from '@/core/errors/use-case-error'
 
-export class CourseAlreadyExistsInThisAccount extends Error implements UseCaseError {
+export class CourseAlreadyExistsInThisAccountError extends Error implements UseCaseError {
   constructor(instructorEmail: string) {
     super(`Course already exists in this account, account email: ${instructorEmail}.`)
   }

diff --git a/...s/module-already-exists-in-this-course.ts → ...le-already-exists-in-this-course-error.ts b/...s/module-already-exists-in-this-course.ts → ...le-already-exists-in-this-course-error.ts
@@ -1,6 +1,6 @@
 import { type UseCaseError } from '@/core/errors/use-case-error'
 
-export class ModuleAlreadyExistsInThisCourse extends Error implements UseCaseError {
+export class ModuleAlreadyExistsInThisCourseError extends Error implements UseCaseError {
   constructor(identifier: string) {
     super(`Module "${identifier}" already exists in this course.`)
   }

diff --git a/src/domain/course-management/application/use-cases/register-course.spec.ts b/src/domain/course-management/application/use-cases/register-course.spec.ts
@@ -6,7 +6,7 @@ import { InMemoryCoursesRepository } from './../../../../../test/repositories/in
 import { InMemoryInstructorRepository } from './../../../../../test/repositories/in-memory-instructors-repository'
 import { InMemoryModulesRepository } from './../../../../../test/repositories/in-memory-modules-repository'
 import { InMemoryStudentsRepository } from './../../../../../test/repositories/in-memory-students-repository'
-import { CourseAlreadyExistsInThisAccount } from './errors/course-already-exists-in-this-account'
+import { CourseAlreadyExistsInThisAccountError } from './errors/course-already-exists-in-this-account-error'
 import { RegisterCourseUseCase } from './register-course'
 
 let inMemoryModulesRepository: InMemoryModulesRepository
@@ -88,6 +88,6 @@ describe('Register course use case', () => {
     })
 
     expect(result.isLeft()).toBe(true)
-    expect(result.value).toBeInstanceOf(CourseAlreadyExistsInThisAccount)
+    expect(result.value).toBeInstanceOf(CourseAlreadyExistsInThisAccountError)
   })
 })
diff --git a/src/domain/course-management/application/use-cases/register-course.ts b/src/domain/course-management/application/use-cases/register-course.ts
@@ -5,7 +5,7 @@ import { type UseCase } from '@/core/use-cases/use-case'
 import { Course } from '../../enterprise/entities/course'
 import { type CoursesRepository } from '../repositories/courses-repository'
 import { type InstructorsRepository } from '../repositories/instructors-repository'
-import { CourseAlreadyExistsInThisAccount } from './errors/course-already-exists-in-this-account'
+import { CourseAlreadyExistsInThisAccountError } from './errors/course-already-exists-in-this-account-error'
 
 interface RegisterCourseUseCaseRequest {
   name: string
@@ -14,7 +14,7 @@ interface RegisterCourseUseCaseRequest {
 }
 
 type RegisterCourseUseCaseResponse = Either<
-ResourceNotFoundError | CourseAlreadyExistsInThisAccount,
+ResourceNotFoundError | CourseAlreadyExistsInThisAccountError,
 {
   course: Course
 }
@@ -40,7 +40,7 @@ export class RegisterCourseUseCase implements UseCase<RegisterCourseUseCaseReque
     const courseWithSameNameInSameAccount = instructorWithCourses.courses.find(courseToCompare => courseToCompare.name === name)
 
     if (courseWithSameNameInSameAccount) {
-      return left(new CourseAlreadyExistsInThisAccount(instructorWithCourses.instructor.email))
+      return left(new CourseAlreadyExistsInThisAccountError(instructorWithCourses.instructor.email))
     }
 
     const course = Course.create({

diff --git a/src/domain/course-management/application/use-cases/register-module-to-course.spec.ts b/src/domain/course-management/application/use-cases/register-module-to-course.spec.ts
@@ -6,7 +6,7 @@ import { InMemoryClassesRepository } from '../../../../../test/repositories/in-m
 import { InMemoryCoursesRepository } from './../../../../../test/repositories/in-memory-courses-repository'
 import { InMemoryInstructorRepository } from './../../../../../test/repositories/in-memory-instructors-repository'
 import { InMemoryModulesRepository } from './../../../../../test/repositories/in-memory-modules-repository'
-import { ModuleAlreadyExistsInThisCourse } from './errors/module-already-exists-in-this-course'
+import { ModuleAlreadyExistsInThisCourseError } from './errors/module-already-exists-in-this-course-error'
 import { RegisterModuleToCourseUseCase } from './register-module-to-course'
 
 let inMemoryCoursesRepository: InMemoryCoursesRepository
@@ -111,6 +111,6 @@ describe('Register module to a course use case', () => {
     })
 
     expect(result.isLeft()).toBe(true)
-    expect(result.value).toBeInstanceOf(ModuleAlreadyExistsInThisCourse)
+    expect(result.value).toBeInstanceOf(ModuleAlreadyExistsInThisCourseError)
   })
 })
diff --git a/src/domain/course-management/application/use-cases/register-module-to-course.ts b/src/domain/course-management/application/use-cases/register-module-to-course.ts
@@ -6,7 +6,7 @@ import { type UseCase } from '@/core/use-cases/use-case'
 import { Module } from '../../enterprise/entities/module'
 import { type CoursesRepository } from '../repositories/courses-repository'
 import { type ModulesRepository } from '../repositories/modules-repository'
-import { ModuleAlreadyExistsInThisCourse } from './errors/module-already-exists-in-this-course'
+import { ModuleAlreadyExistsInThisCourseError } from './errors/module-already-exists-in-this-course-error'
 
 interface RegisterModuleToCourseUseCaseRequest {
   name: string
@@ -17,7 +17,7 @@ interface RegisterModuleToCourseUseCaseRequest {
 }
 
 type RegisterModuleToCourseUseCaseResponse = Either<
-ResourceNotFoundError | ModuleAlreadyExistsInThisCourse | NotAllowedError,
+ResourceNotFoundError | ModuleAlreadyExistsInThisCourseError | NotAllowedError,
 {
   module: Module
 }
@@ -49,7 +49,7 @@ export class RegisterModuleToCourseUseCase implements UseCase<RegisterModuleToCo
     const moduleWithSameNameInSameCourse = completeCourse.modules.find(moduleToCompare => moduleToCompare.name === name)
 
     if (moduleWithSameNameInSameCourse) {
-      return left(new ModuleAlreadyExistsInThisCourse(name))
+      return left(new ModuleAlreadyExistsInThisCourseError(name))
     }
 
     const module = Module.create({