-
Notifications
You must be signed in to change notification settings - Fork 0
Add single-file hangboard packages and onboard 5 new boards #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
183d38c
docs: design single-file hangboard packages
Asherlc aee65cf
refactor: model physical hangboard holds
Asherlc e4f3d87
fix: enforce shared hold geometry paths
Asherlc 7200730
refactor: embed Compact II hold geometry
Asherlc 54f87ba
refactor: discover hangboards by directory
Asherlc efe8f30
fix: complete directory-discovered board integration
Asherlc 97284bf
feat: add Beastmaker 1000 holds
Asherlc e2c0ce9
feat: add Beastmaker 2000 holds
Asherlc fd09fd1
feat: add deWoodstok Woodbord holds
Asherlc 8cc0099
feat: add Escape Beta 22 holds
Asherlc f077a8f
feat: add Lattice Triple Rung holds
Asherlc 8741eb8
Merge origin/main into aquatic-frog
Asherlc 39d0dd4
Restore missing board_artwork compatibility module
Asherlc 166e568
Fix stale staging test fixtures and tolerate backup cleanup failure
Asherlc 389fc59
Fix hold geometry bounds and aspect-ratio metadata mismatches
Asherlc a6a92d2
Update expected Hangboards directory count for Escape Beta 22
Asherlc 72ac06c
Fix Swift build breaks from the main merge
Asherlc c6b8607
Add sourced hold depth/feature metadata for 4 new boards
Asherlc 23afdc1
Pin BoardCatalog.defaultBoard to Compact II, update board-count test
Asherlc 0ff7d43
Delete BoardDesignLanguage.swift and finish the physical-geometry ref…
Asherlc 6ef9bfd
Merge origin/main (#173 board-package consolidation)
Asherlc f4939ae
Address still-applicable CodeRabbit findings on the git-actions endpo…
Asherlc fe0763e
Address CodeRabbit findings on the HangboardPipeline package
Asherlc a3ca621
Address remaining CodeRabbit findings across the pipeline, Workbench,…
Asherlc 8a51e9f
Resolve remaining live CodeRabbit findings on PR #208
Asherlc fd85701
Address latest CodeRabbit review round on PR #208
Asherlc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
.superpowers/sdd/2026-08-14-single-file-hangboard-schema/task-2-fix-report.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # Task 2 review-fix report | ||
|
|
||
| Date: 2026-08-14 | ||
|
|
||
| Status: complete | ||
|
|
||
| ## Review findings and fixes | ||
|
|
||
| 1. Plan-owned semantic mappings were being replaced by board-package data when the bundled plan library was loaded. Validation and resolution also reconstructed mappings from `TrainingBoard`, and the migration seed still read removed package semantics. The store now preserves the plan document unchanged, validation and resolution use `PlanLibraryDefinition.boardMappings`, and the migration fallback owns the exact existing Compact II mappings. The physical board package remains semantic-free. | ||
|
|
||
| 2. Workbench discovery had a second, incompatible ID grammar, accepted dotted directory slugs, treated non-minimal directories as drafts, and exposed duplicate published board IDs. Discovery now uses the canonical catalog predicates, accepts canonical IDs containing `_`, restricts package slugs to the canonical flat slug grammar, accepts only an exact `assets/primary.png` draft, and diagnoses/removes every ambiguous published ID. | ||
|
|
||
| 3. Canonical package materialization collapsed multi-piece holds onto repeated keys, repeated `pieceIndex = 0`, reported physical-hold counts as region counts, and used union hold bounds for each piece. Every geometry piece now receives a stable unique region key, integer ID, local piece index, and piece-specific bounds/anchor, while `metadata.holdID` preserves the physical hold identity. Stage 4 continues to group paths by physical hold and validation deduplicates semantic mappings by that identity. | ||
|
|
||
| 4. Package replacement is rollback-safe but cannot be reader-atomic for raw filesystem readers because the existing directory is temporarily renamed away. The code and tests now state that boundary accurately. Workbench publication takes an exclusive lock on the stable `Hangboards` root inode and repository snapshots take a shared lock, so cooperating readers never observe the rename-away window. | ||
|
|
||
| ## Test-first evidence | ||
|
|
||
| RED evidence was captured before each implementation change: | ||
|
|
||
| - Four focused Swift plan tests failed because `edge-19`/`edge-29` disappeared from the effective plan mappings and the fallback seed attempted to read package semantics. | ||
| - Six focused Python tests failed for extra-file drafts, incompatible slug/ID handling, duplicate IDs, repeated multi-piece keys and metadata, and a reader observing the package rename-away window. | ||
|
|
||
| GREEN verification: | ||
|
|
||
| - Focused Swift plan regressions: 4 passed (`PlanStorageTests` mapping preservation, migration fallback, validation authority, and resolver override). | ||
| - Directly impacted Python suites: 72 passed, 19 existing Pillow deprecation warnings. | ||
| - Full Task 2 Python set: 96 passed, 19 existing Pillow deprecation warnings. | ||
| - Workbench server suite: 120 passed. | ||
| - `git diff --check`: passed. | ||
|
|
||
| A broader `PlanStorageTests` + `BoardPackageStoreTests` Xcode run was time-boxed and stopped while still building; it emitted no test failure and did not reach the test runner. Its exact isolated simulator and derived data were deleted afterward. No broader-suite success is claimed here. | ||
|
|
||
| ## Files changed | ||
|
|
||
| - `HangTen/Models/PlanStorage.swift` | ||
| - `HangTen/Models/TrainingModels.swift` | ||
| - `HangTenTests/PlanStorageTests.swift` | ||
| - `Tools/HangboardPipeline/src/hangboard_vectorizer/board_catalog.py` | ||
| - `Tools/HangboardPipeline/src/hangboard_vectorizer/board_library.py` | ||
| - `Tools/HangboardPipeline/src/hangboard_vectorizer/workbench_promotion.py` | ||
| - `Tools/HangboardPipeline/src/hangboard_vectorizer/workbench_validation.py` | ||
| - `Tools/HangboardPipeline/tests/test_board_library.py` | ||
| - `Tools/HangboardPipeline/tests/test_workbench_end_to_end.py` | ||
|
|
||
| ## Remaining concern | ||
|
|
||
| Non-cooperating raw filesystem readers are outside the publication lock protocol and may still observe the rename-away interval. The supported Workbench reader path is coordinated and covered by a deterministic concurrency regression test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.