Fixed StartUpdatesNativeAsync for indicate

AskBojesen · May 19, 2024 · 74b0446 · 74b0446
1 parent 1e19fa8
commit 74b0446
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 5 deletions.
diff --git a/Source/BLE.Client/BLE.Client.WinConsole/PluginDemos.cs b/Source/BLE.Client/BLE.Client.WinConsole/PluginDemos.cs
@@ -103,7 +103,7 @@ public async Task Connect_Read_Services_Disconnect_Loop()
             string bleaddress = BleAddressSelector.GetBleAddress();
             var id = bleaddress.ToBleDeviceGuid();
             var connectParameters = new ConnectParameters(connectionParameterSet: ConnectionParameterSet.Balanced);
-            new Task(ConsoleKeyReader).Start();            
+            new Task(ConsoleKeyReader).Start();
             using (IDevice dev = await Adapter.ConnectToKnownDeviceAsync(id, connectParameters))
             {
                 int count = 1;
@@ -151,7 +151,7 @@ public async Task Connect_Read_Services_Dispose_Loop()
             var connectParameters = new ConnectParameters(connectionParameterSet: ConnectionParameterSet.Balanced);
             new Task(ConsoleKeyReader).Start();
             int count = 1;
-            while (true)  
+            while (true)
             {
                 await Task.Delay(100);
                 Write($"---------------- {count++} ------- (Esc to stop) ------");
@@ -163,16 +163,35 @@ public async Task Connect_Read_Services_Dispose_Loop()
                 {
                     var characteristics = await service.GetCharacteristicsAsync();
                     charlist.AddRange(characteristics);
+                    foreach (Characteristic characteristic in characteristics)
+                    {
+                        if (characteristic.Properties.HasFlag(CharacteristicPropertyType.Indicate)
+                            || characteristic.Properties.HasFlag(CharacteristicPropertyType.Notify))
+                        {
+                            Write($"Characteristic.Properties: {characteristic.Properties}");
+                            try
+                            {
+                                await characteristic.StartUpdatesAsync();
+                            } catch { }
+                        }
+                    }
                 }
 
                 foreach (var service in services)
                 {
                     service.Dispose();
                 }
+                foreach (Characteristic characteristic in charlist)
+                {
+                    try
+                    {
+                        await characteristic.StopUpdatesAsync();
+                    } catch { }
+                }
                 charlist.Clear();
                 Write("Waiting 3 secs");
                 await Task.Delay(3000);
-                await Adapter.DisconnectDeviceAsync(dev);                
+                await Adapter.DisconnectDeviceAsync(dev);
                 Write("Disposing");
                 dev.Dispose();
             }

diff --git a/Source/Plugin.BLE/Windows/Characteristic.cs b/Source/Plugin.BLE/Windows/Characteristic.cs
@@ -59,8 +59,18 @@ protected override async Task StartUpdatesNativeAsync(CancellationToken cancella
             NativeCharacteristic.ValueChanged -= OnCharacteristicValueChanged;
             NativeCharacteristic.ValueChanged += OnCharacteristicValueChanged;
 
-            var result = await NativeCharacteristic.WriteClientCharacteristicConfigurationDescriptorWithResultAsync(GattClientCharacteristicConfigurationDescriptorValue.Notify);
-            result.ThrowIfError();
+            if (Properties.HasFlag(CharacteristicPropertyType.Notify))
+            {
+                var result = await NativeCharacteristic.WriteClientCharacteristicConfigurationDescriptorWithResultAsync(GattClientCharacteristicConfigurationDescriptorValue.Notify);
+                result.ThrowIfError();
+            } else if (Properties.HasFlag(CharacteristicPropertyType.Indicate))
+            {
+                var result = await NativeCharacteristic.WriteClientCharacteristicConfigurationDescriptorWithResultAsync(GattClientCharacteristicConfigurationDescriptorValue.Indicate);
+                result.ThrowIfError();
+            } else
+            {
+                throw new Exception($"StartUpdatesNativeAsync for {Uuid} failed since not Notify or Indicate");
+            }
         }
 
         protected override async Task StopUpdatesNativeAsync(CancellationToken cancellationToken = default)