-
-
Notifications
You must be signed in to change notification settings - Fork 979
feat: 新增两个插件生命周期事件钩子 & 为插件metadata.yaml引入dependencies字段 #1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
80eb939
feat: add hooks -- on_star_activated, on_star_deactivated
Flartiny 2340c5c
feat: Allow dependencies field in metadata.yaml
Flartiny 1866406
refactor: Introducing networkx to manage the process of plugin loading
Flartiny d065cf0
Merge branch 'master' into dev
Flartiny c61e3c9
Merge branch 'releases/4.0.0' into pr/Flartiny/1925
Raven95676 2783cc0
chore: clean code
Raven95676 824c364
Merge branch 'releases/4.0.0' into dev
Raven95676 7f8d0e8
fix: 修复插件加载顺序,确保系统插件优先加载
Raven95676 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,4 +39,5 @@ faiss-cpu | |
| aiosqlite | ||
| py-cord>=2.6.1 | ||
| slack-sdk | ||
| pydub | ||
| pydub | ||
| networkx | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里如果不用 networkx 的话可以实现嘛?可能目前基于图的长期记忆还暂时不会引入。
tips: 抱歉这么久没处理;这个 PR 打算放到 releases/4.0.0 分支中;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
理论上可行, 即在 2340c5c 基础上修改,之前稍微尝试了一下感觉比较冗长(时间有点久了,只记得至少有一处细节手动处理起来比较复杂,而交由networkx管理相对清晰)并且不易扩展(比如目前想到的是依赖项后跟版本号进行更细致的区分)