Skip to content

Conversation

smaerup
Copy link
Collaborator

@smaerup smaerup commented Mar 13, 2024

No description provided.

@smaerup smaerup requested a review from larsgk March 13, 2024 13:35
@smaerup smaerup force-pushed the use_leds_to_indicate_state branch 2 times, most recently from 1383d8c to 4468f51 Compare March 19, 2024 09:51
@smaerup smaerup force-pushed the use_leds_to_indicate_state branch from 4468f51 to 4e50951 Compare March 19, 2024 10:01
@smaerup smaerup requested a review from jthm-ot March 19, 2024 10:05
@larsgk
Copy link
Collaborator

larsgk commented Mar 19, 2024

Good idea to have LED indicators... however, maybe we can have 2 small adjustments:

  1. we need guards around all GPIO/LED code so it compiles and runs on devices that don't have the config
  2. maybe we can consider to have the RGB PWM code from https://github.com/larsgk/simple-web-zephyr/blob/main/app/src/rgb_led.c (if we want some more color/effect options... I was actually considering to introduce that)

Copy link
Collaborator

@larsgk larsgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should guard the code on devices that don't have the GPIO/LED config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants