New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Line styling for GeofencingZones #4787

Draft

marius-at-atb wants to merge 2 commits into master from marius/geofencing-zones-line-styling

Contributor

marius-at-atb commented Oct 30, 2024 •

edited

Loading

Draft PR until some other parts are ready

Resolves https://github.com/AtB-AS/kundevendt/issues/18745

In this PR:

GeofencingZones line thickness is set based on zoom.
lineIsDashed in GeofencingZoneStyle is supported.

Ideally we could have lineDasharray directly in GeofencingZoneStyle, but Mapbox doesn't support ['get', 'someProp'] at all for this prop.

Example:

marius-at-atb added 2 commits

October 30, 2024 12:51


          Support for lines to be dashed and have zoom based thickness

1cfa326


          Add todo

12e5dc3

marius-at-atb self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gorandalum Awaiting requested review from gorandalum gorandalum will be requested when the pull request is marked ready for review gorandalum is a code owner

jorelosorio Awaiting requested review from jorelosorio jorelosorio will be requested when the pull request is marked ready for review jorelosorio is a code owner

rosvik Awaiting requested review from rosvik rosvik will be requested when the pull request is marked ready for review rosvik is a code owner

strandlie Awaiting requested review from strandlie strandlie will be requested when the pull request is marked ready for review strandlie is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet