Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade mobile token SDK to version 3.3.2 #5029

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reidzeibel
Copy link
Member

@reidzeibel reidzeibel commented Feb 18, 2025

closes: https://github.com/AtB-AS/kundevendt/issues/19973

old PR: #4982

Created a new PR because the old one has too much changes to follow and contains lots of changes.

References:

Changes:

  • Updated podfile (see Abt-Developer-Docs above)
  • Updated code to match the changes on the new SDK.
  • Added parseBffCallErrors to parse errors from the SDK, see https://github.com/entur/abt-mobile-client-sdk/pull/368.
  • Update validate token function to because the old function is now deprecated.
  • Added debug menu for creating new token, sabotage token creation and expands the information shown on the mobile token debug menu (reattestation, remote/native errors if any).
  • Intercom status now sends attested, non-attested, error, instead of just success or error
  • Adjusts local and remote logger based on the changes made to the SDK.
  • Adds logging during the token creation process, now will send breadcrumbs and errors to bugsnag for further investigation
  • New token error handling, now uses the recommended issue resolution from the SDK. The priority of error handling is now:
    • If only needs renewal, renew.
    • Else, check the recommended issue resolution path from the SDK, which results in either reset or do nothing.
    • Else, throw the error
  • Adds new payload to the init request, now sends in device information for a more detailed debugging on Entur's side.
  • Adds a new function reattestMobileToken for delayed reattestation.
  • Move wipeToken() function to utils file and added some logging.

@reidzeibel reidzeibel self-assigned this Feb 18, 2025
@reidzeibel reidzeibel added the App label Feb 18, 2025
@reidzeibel reidzeibel marked this pull request as ready for review February 18, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant