This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Make existence of documentation more apparent #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atem18
reviewed
May 31, 2024
| @@ -2,6 +2,8 @@ | |||
| Python client for Kraken API REST and Kraken Websockets API using httpx and websockets. | |||
| Supports both sync and async for API REST. | |||
|
|
|||
| Documentation: https://kraky.readthedocs.io/en/latest/ | |||
There was a problem hiding this comment.
In Fastapi repo, they put Documentation in bold : https://github.com/tiangolo/fastapi
If we want people to find the documentation, makeing it bold can certainly help.
There was a problem hiding this comment.
Can you also rebase on main, I did some changes to the workflow so that it passes ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #366