Resolve an issue with the servlet mapping for JSR 356 #2331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some digging about #2316 (and #2326) I came to a conclusion that servlet mapping with trailing slash is incorrect in
JSR 356
[1]. The mapping value must have a leading '/' and should not contain empty parts:The trailing slash can be ignored or treated as missed part, as we saw in a Tomcat's implementation (#2320). Up to #2316 everything worked correctly: the
/mapping/
was cleared on/mapping
and were not registering templates with trailing slash.This PR:
[1] https://jcp.org/aboutJava/communityprocess/mrel/jsr356/index.html
[2] https://www.w3.org/Addressing/URL/url-spec.txt