Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSR356Endpoint to read attributes from the handshake session #2504

Merged

Conversation

amy-b-cheng
Copy link
Contributor

@amy-b-cheng amy-b-cheng commented Mar 21, 2024

Fixes #2502

Behavior when using Jetty 9 was that attributes added by filters were copied from the HTTPRequest to the AtmosphereRequest. In Jetty 10, we are using JSR356Endpoint which does not copy the attributes. I couldn't figure out how to get the request attributes but instead will settle for using the attributes on the handshakeSession.

@jfarcand jfarcand merged commit d54e08e into Atmosphere:atmosphere-2.7.x Mar 21, 2024
5 checks passed
@amy-b-cheng
Copy link
Contributor Author

@jfarcand any idea when you plan to release next?

@jfarcand
Copy link
Member

jfarcand commented Apr 2, 2024

@amy-b-cheng Today!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSR356Endpoint dropping custom attributes on the HTTP request
2 participants