Skip to content

fix(models): de-dupe favorites by model id (nickname no longer lists a model twice) #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yanalialiuk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(models): de-dupe favorites by model id (nickname no longer lists a model twice) #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion web-app/src/containers/DropdownModelProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,9 +306,23 @@ const DropdownModelProvider = memo(function DropdownModelProvider({

// Get favorite models that are currently available
const favoriteItems = useMemo(() => {
return searchableItems.filter((item) =>
const matched = searchableItems.filter((item) =>
favoriteModels.some((fav) => fav.id === item.model.id)
)
// A model id can appear under more than one provider (e.g. llamacpp +
// llamacpp-upstream). Favorites are keyed by model id, so collapse to a
// single entry per id — otherwise nicknaming one copy makes the favorite
// show twice (once as the nickname, once as the raw id). Prefer the copy
// that carries a user nickname (model.displayName); keep first match
// otherwise. Map.set on an existing key preserves insertion order.
const byId = new Map<string, SearchableModel>()
for (const item of matched) {
const existing = byId.get(item.model.id)
if (!existing || (!existing.model.displayName && item.model.displayName)) {
byId.set(item.model.id, item)
}
}
return Array.from(byId.values())
}, [searchableItems, favoriteModels])

// Filter models based on search value
Expand Down