fix(ui): improve hover contrast for ghost buttons and the settings menu#141
Closed
cashcon57 wants to merge 1 commit into
Closed
fix(ui): improve hover contrast for ghost buttons and the settings menu#141cashcon57 wants to merge 1 commit into
cashcon57 wants to merge 1 commit into
Conversation
Contributor
Author
|
Folded into #140, which now covers both the selected and hover contrast fixes as one comprehensive pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Follow-on contrast polish to #106 / #140 (which addressed selected states). Those
PRs left the hover states using absolute
bg-accent/bg-secondaryoverlays,which collapse against light backgrounds (both tokens are ≈
0.97in light, nearlyidentical to the surfaces they sit on) — so hover was barely visible, especially in
light mode.
Two fixes, both switching hover to a background-relative
bg-foreground/10overlay so it's legible on any surface in both themes, and stays a step below the
selected state's
bg-foreground/20(hover < selected):components/ui/button.tsx) — theghostvariant'shover:bg-accentwas the faint hover on every ghost button (icon toolbars likethe message copy/edit/delete/regenerate actions, header icons, menus, …). This is
a shared design-system change — it affects all
variant="ghost"buttons app-wide(~80 usages).
outlineis intentionally left as-is (it has a border).SettingsMenu.tsx) — the category links usedhover:bg-secondarywhile the model-provider rows used
hover:bg-secondary/60, so they didn't matchand both were faint in light. Unified to the same
hover:bg-foreground/10.Styling-only change (no logic, no new dependencies), verified in a local dev build.
Before / After
Fixes Issues
No linked issue — UX/accessibility polish (follow-on to the #107 contrast work).
Self Checklist