smoke: fix CUDA device assert and tg128 column#42
Merged
Conversation
The CUDA device line in the bench log is 'Device 0: NVIDIA ...' with no 'cuda' on the same line, so the combined regex never matched and a fully working CUDA run (60k t/s pp512 on an RTX 5090) was reported as FAIL. Also the tg128 extraction read the test-name column instead of the t/s column. Both asserts validated against the real bench.log from that run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual validation run of the committed smoke scripts on a rented RTX 5090 (dev-latest, commit f2757df):
cudaandNVIDIAon the same log line, while the bench log prints the device asDevice 0: NVIDIA GeForce RTX 5090, compute capability 12.0.Fixes:
Device [0-9]+: NVIDIA(validated against the real bench.log from the failing run)