ci: resilient release publish (a failed backend must not block the release)#51
Merged
Conversation
…s the release publish-release had no if:always(), so one failed backend build (e.g. the new ROCm job) would skip publish entirely and ship NOTHING. Add if:always() gated on verify-version, publish whatever archives exist, and list any missing backends in the notes (mirrors publish-dev-latest). Also add the linux CUDA and ROCm rows to the notes table (CUDA was missing).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #49.
publish-releasehad noif: always(), so if any backend build fails (e.g. the new ROCm job on its first real run) the publish step is skipped and the release ships nothing — blocking even the working backends.if: always() && needs.verify-version.result == 'success'— publish regardless of individual backend outcomes, still gated on the version check.publish-dev-latest).Net effect: ROCm in the release if it builds; the release still ships (minus ROCm, with a note) if it doesn't.