hotfix: lean ROCm archive so b10018-1.2.0 can publish#53
Open
worthant wants to merge 1 commit into
Open
Conversation
The ROCm archive hit 9.6 GB and blew past GitHub's 2 GB asset limit, so publish-release 422'd and b10018-1.2.0 failed to publish. Cause: I bundled the whole rocBLAS/hipBLASLt Tensile kernel database (kernels for every gfx arch) to make the archive self-contained. Drop it: ship binaries + libggml-hip.so (~0.45 GB) only, require the system ROCm runtime like upstream's ROCm builds. Archive drops ~9.6 GB -> ~0.6 GB. Adds a README-ROCm.txt noting the runtime requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b10018-1.2.0 built all 9 backends successfully but publish-release 422'd: the ROCm .zip exceeded GitHub's 2 GB asset limit (archive was 9.6 GB).
Root cause: the ROCm archive bundled the full rocBLAS/hipBLASLt Tensile kernel database (precompiled GEMM kernels for every gfx arch) to be self-contained — that's multi-GB. Stock llama.cpp ROCm builds don't do this.
Fix: lean archive — binaries +
libggml-hip.so(~0.45 GB) only, require the system ROCm runtime (documented in a bundled README-ROCm.txt). Archive drops from ~9.6 GB to ~0.6 GB, well under the limit.Admin-merge this, then I delete + re-push the
b10018-1.2.0tag to rebuild and publish the release (with ROCm). CI-only change; I'll sync dev right after.