Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RenderMeasurer #28

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

jcavar
Copy link
Contributor

@jcavar jcavar commented Mar 15, 2024

RenderMeasurer measures CPU load of given audio unit. It can be used for user facing CPU meter, but also for automated performance testing.

RenderMeasurer measures CPU load of given audio unit. It can be used for
user facing CPU meter, but also for automated performance testing.
}

_Nonnull AURenderObserver createObserver() {
auto sharedThis = std::shared_ptr<RenderMeasurer>(this);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this pattern is realtime safe, but I would like someone more experienced with C++ to comment on it.

@aure
Copy link
Member

aure commented Mar 15, 2024

I think you'd have to bump up the Swift Version number to get this PR to pass tests. Do you want to try that or shall I just accept the PR?

@jcavar
Copy link
Contributor Author

jcavar commented Mar 20, 2024

@aure I've updated Swift version to 5.9. iOS tests are now passing, but macOS and tvOS are failing. It seems like failures are in other areas that I haven't touched, were these passing before?

@aure aure merged commit 028c7b4 into AudioKit:main Mar 20, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants