Update Settings.sampleRate for iOS 18 #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -20,7 +20,7 @@ let package = Package( | |||
| .package(url: "https://github.com/AudioKit/Waveform", branch: "visionos"), | |||
| .package(url: "https://github.com/AudioKit/Flow", from: "1.0.0"), | |||
| .package(url: "https://github.com/AudioKit/PianoRoll", from: "1.0.0"), | |||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.9.4"), | |||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.9.7"), | |||
There was a problem hiding this comment.
Comma Spacing Violation: There should be no space before and one after any comma. (comma)
Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
| @@ -20,7 +20,7 @@ let package = Package( | |||
| .package(url: "https://github.com/AudioKit/Waveform", branch: "visionos"), | |||
| .package(url: "https://github.com/AudioKit/Flow", from: "1.0.0"), | |||
| .package(url: "https://github.com/AudioKit/PianoRoll", from: "1.0.0"), | |||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.9.4"), | |||
| .package(url: "https://github.com/orchetect/MIDIKit", from: "0.9.7"), | |||
There was a problem hiding this comment.
Comma Spacing Violation: There should be no space before and one after any comma. (comma)
Trailing Comma Violation: Collection literals should not have trailing commas. (trailing_comma)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In iOS 18, the default device sample rate goes from 44_100 to 48_000. This PR checks the AVAudioSession's sampleRate and updates Settings.sampleRate if needed (current default is 44_100).
Additionally, this change could be applied to how the value is initialized in the Settings class of the AudioKit package.