pal: correct logic of stream type check when setting the gain #35
Conversation
…ould be a logical AND operation, not a bitwise AND.
|
Thanks @MrChangMM for raising the Pull Request and proposing the change 🙌 Please add a Developer Certificate of Origin DCO sign-off line to your commit by committing with the -s or --signoff options. To keep history readable, it would be really helpful to limit the commit title/subject to ~72 characters and put additional context in the body. |
quic-plai
changed the title
quic-plai
changed the title
quic-plai
left a comment
quic-plai
left a comment
There was a problem hiding this comment.
Thanks for submitting the fix. It looks good. At the same time, can you edit the commit text like the following. Github does not allow me to edit the commit text.
pal: correct logic of stream type check when setting the gain
Current condition is always evaluated to be true because PAL_STREAM_PCM_OFFLOAD is a non-zero value. Update the condition to ensure gain is set only when stream type is PAL_STREAM_PCM_OFFLOAD or PAL_STREAM_DEEP_BUFFER
… this should be a logical AND operation, not a bitwise AND." This reverts commit 129ad02.
Change condition to use && and compare PAL_STREAM_PCM_OFFLOAD with sAttr.type so the branch only runs when sAttr.direction is output and sAttr.type is DEEP_BUFFER or PCM_OFFLOAD.
quic-plai
left a comment
quic-plai
left a comment
There was a problem hiding this comment.
謝謝新的補丁 但是要通過系統檢查
麻煩您加上 DCO (Developer Certificate of Origin), 請參照以下指令
git commit --amend --signoff
Commit text 每一行最多72個字 格式參照以下
pal: <總結>
<解釋遇見的問題 然後解釋改動>
麻煩 git squash 4個commits成1個commit
5 participants
…ould be a logical AND operation, not a bitwise AND.