Skip to content

Conversation

gap-editor
Copy link

No description provided.

Copy link

changeset-bot bot commented May 27, 2025

⚠️ No Changeset found

Latest commit: 9b240a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gap-editor gap-editor changed the title fix: typo in v fix: typo in solana-programs/claimable-tokens/cli/src/main.rs May 27, 2025
Copy link
Contributor

@rickyrombo rickyrombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gap-editor !

Thanks for your contribution! Sorry for the delayed review. I left a comment - hopefully that makes sense. Appreciate you taking a look though!

let mint = pubkey_of(args, "mint").unwrap();
let program_id = pubkey_of(args, "program_id").unwrap();
println!("Recieved mint {:?}", mint);
println!("Recieved program_id {:?}", program_id);
Copy link
Contributor

@rickyrombo rickyrombo Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's definitely a typo alright.

Unfortunately, the bar for a new deploy of the program is quite high, and it's important that this code matches what code is currently deployed on the production program deploy. With that in mind, I think we're stuck with this typo until a change that meets the bar and requires us to deploy the program to a new address, in which case we can bundle this change in with that new deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants