Skip to content

Conversation

DejayJD
Copy link
Contributor

@DejayJD DejayJD commented Aug 28, 2025

Description

Clean up some of the mocks & mock data scattered across our tests

  • Mock data is now in the fixtures/ folder, and should be referencing other mock data (e.g. mockTrack is owned by artistUser)
  • Mocks in their own file, each a separate fn that takes in params to configure the response
    • TODO: need to derive these types better, need to see if we can get incoming expected data types from SDK?
  • A couple more provider things set up in our tests (needed for asset test)
  • Change dom env to happy-dom, experimental for now. Supposed to be faster & lighter

How Has This Been Tested?

vitest

Copy link

changeset-bot bot commented Aug 28, 2025

⚠️ No Changeset found

Latest commit: 900f823

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@DejayJD DejayJD requested review from a team and dylanjeffers August 28, 2025 19:40
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job with the fixtures and asset-details test

return (
<>
<ModalDrawer
<ResponsiveModal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting what's the idea here? also heads up this component will get dropped this week


it('should render the profile page for a non-artist', async () => {
renderProfilePage()
it.only('should render the profile page for a non-artist', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants