Skip to content

Conversation

dharit-tan
Copy link
Contributor

@dharit-tan dharit-tan commented Oct 10, 2025

Description

AI ftw

How Has This Been Tested?

Tested with some staging mints:
$FINE: https://solscan.io/account/14k6A6Two8XqZmSiHibr4JudcXwJqXzUJxH7D2rpHLq6

Copy link

changeset-bot bot commented Oct 10, 2025

⚠️ No Changeset found

Latest commit: 4dc8842

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@rickyrombo rickyrombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests for the decoding/encoding of the instruction?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file imo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want a script folder in this package - let's try to keep this as a "library" rather than something you run

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file imo

"test": "vitest run",
"test:watch": "vitest"
"test:watch": "vitest",
"init-reward-manager": "ts-node --project scripts/tsconfig.json scripts/initRewardManager.ts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this belongs here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could maybe see putting this in an examples folder that doesn't get shipped with the package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah we can remove i just wanted to post up a draft for peeps

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

dharit-tan added a commit that referenced this pull request Oct 13, 2025
### Description
Implement the reward manager init instruction in typescript in spl
package.

### How Has This Been Tested?

Tested with a script locally, see
#13229.
Successful tx:
https://explorer.solana.com/tx/3aezu4NokWVfNqc7YDL5cJty71ogLdkGMiN9h2qfujRcwAwbrZ7VktXeyWNXEMvvgQUbNHg5BtdUdXXTuskMTXEo?cluster=mainnet-beta
raymondjacobson pushed a commit that referenced this pull request Oct 20, 2025
Implement the reward manager init instruction in typescript in spl
package.

Tested with a script locally, see
#13229.
Successful tx:
https://explorer.solana.com/tx/3aezu4NokWVfNqc7YDL5cJty71ogLdkGMiN9h2qfujRcwAwbrZ7VktXeyWNXEMvvgQUbNHg5BtdUdXXTuskMTXEo?cluster=mainnet-beta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants