-
Notifications
You must be signed in to change notification settings - Fork 123
Reward Manager Init in typescript + script #13229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests for the decoding/encoding of the instruction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this file imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want a script folder in this package - let's try to keep this as a "library" rather than something you run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file imo
"test": "vitest run", | ||
"test:watch": "vitest" | ||
"test:watch": "vitest", | ||
"init-reward-manager": "ts-node --project scripts/tsconfig.json scripts/initRewardManager.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this belongs here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could maybe see putting this in an examples folder that doesn't get shipped with the package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nah we can remove i just wanted to post up a draft for peeps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this
### Description Implement the reward manager init instruction in typescript in spl package. ### How Has This Been Tested? Tested with a script locally, see #13229. Successful tx: https://explorer.solana.com/tx/3aezu4NokWVfNqc7YDL5cJty71ogLdkGMiN9h2qfujRcwAwbrZ7VktXeyWNXEMvvgQUbNHg5BtdUdXXTuskMTXEo?cluster=mainnet-beta
Implement the reward manager init instruction in typescript in spl package. Tested with a script locally, see #13229. Successful tx: https://explorer.solana.com/tx/3aezu4NokWVfNqc7YDL5cJty71ogLdkGMiN9h2qfujRcwAwbrZ7VktXeyWNXEMvvgQUbNHg5BtdUdXXTuskMTXEo?cluster=mainnet-beta
Description
AI ftw
How Has This Been Tested?
Tested with some staging mints:
$FINE: https://solscan.io/account/14k6A6Two8XqZmSiHibr4JudcXwJqXzUJxH7D2rpHLq6