Skip to content

Add setuptools to install_requires for pkg_resources compatibility #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bob-autoidm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add setuptools to install_requires for pkg_resources compatibility #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
'PyMySQL==0.9.3',
'backoff==1.8.0',
'mysql-replication==0.22',
'setuptools',

@cursor cursor Bot Mar 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unpinned setuptools allows versions without pkg_resources

High Severity

The PR description states that setuptools>=82 removed pkg_resources entirely, yet setuptools is added here without an upper version bound. This means pip can resolve to setuptools 82+, which no longer includes pkg_resources, completely defeating the purpose of this fix. The dependency needs an upper bound (e.g., setuptools<82) to guarantee pkg_resources remains available.

Fix in Cursor Fix in Web

],
extras_require={
'dev': ['pylint==2.8.3']
Expand Down