fix: correctly use bytebuffer slice in decodecontexts method #2925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tino Britty <[email protected]>
brittytino
requested review from
1sonofqiu,
Gezi-lzq,
superhx and
woshigaopp
as code owners
|
|
superhx
previously approved these changes
Oct 10, 2025
|
@brittytino Hi, the fix is great, but I cannot merge the PR before you fix the CI problems. |
|
@superhx i've fixed that CI |
Gezi-lzq
approved these changes
Oct 22, 2025
1sonofqiu
approved these changes
Oct 22, 2025
Gezi-lzq
pushed a commit
that referenced
this pull request
Oct 28, 2025
* fix: correctly use bytebuffer slice in decodecontexts method Signed-off-by: Tino Britty <[email protected]> * eckstyle] [ERROR] RESOLVED --------- Signed-off-by: Tino Britty <[email protected]>
Gezi-lzq
added a commit
that referenced
this pull request
Oct 28, 2025
…2976) * fix: correctly use bytebuffer slice in decodecontexts method * eckstyle] [ERROR] RESOLVED --------- Signed-off-by: Tino Britty <[email protected]> Co-authored-by: Tino Britty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the decodeContexts method in the FailoverListener class to properly use the ByteBuffer slice. Previously, the slice was created but not used, which could lead to incorrect reading of bytes and potential decoding errors.
The fix assigns the sliced buffer to a variable and reads from it, ensuring correct handling of the ByteBuffer without modifying the original buffer's position.
Changes
Why
This correction ensures the failover context decoding is reliable and respects ByteBuffer semantics, preventing subtle bugs in failover context processing.
No other functionality or features were changed.