fix(binder): enhance RecordBinder to support TIMESTAMP and TIME types in union handling #2981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypes in union handling
Gezi-lzq
requested review from
1sonofqiu,
superhx and
woshigaopp
as code owners
Gezi-lzq
requested review from
Copilot and
superhx
and removed request for
1sonofqiu,
superhx and
woshigaopp
Gezi-lzq
changed the title
Gezi-lzq
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR refactors test code to improve test coverage and maintainability by introducing helper methods for comprehensive round-trip testing of Avro-to-Iceberg conversions, and fixes a bug in handling optional timestamp and time fields.
- Introduced
assertFieldRoundTripshelper method to test both direct and optional (union with null) field conversions - Added support for resolving union types in TIMESTAMP and TIME fields in RecordBinder
- Updated field count expectations to account for optional field handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| AvroRecordBinderTest.java | Refactored test methods to use assertFieldRoundTrips helper for comprehensive testing of both direct and optional fields; added new test for union field counting; updated field count assertions |
| RecordBinder.java | Extended union resolution logic to include TIMESTAMP and TIME types alongside existing MAP and LIST types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Gezi-lzq
changed the title
superhx
approved these changes
Nov 3, 2025
Gezi-lzq
added a commit
that referenced
this pull request
Nov 4, 2025
…ypes in union handling (#2981) * feat(timestamp): enhance RecordBinder to support TIMESTAMP and TIME types in union handling * test(avro): add missing import for AvroRecordBinderTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2979