Fix/improve restart recovery - #780
Conversation
|
Caution Review failedFailed to post review comments 📝 WalkthroughWalkthroughThis pull request introduces a major architectural refactoring of the auto-mode service layer, including new planning documentation, updated Claude model versions, Docker enhancements for Playwright support, and comprehensive service decomposition replacing the monolithic AutoModeService with a facade pattern, global service, and specialized orchestrators for execution, pipelines, and approvals. Changes
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @gsxdsm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant architectural overhaul of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive set of planning and documentation files for a major refactoring of the AutoModeService into smaller, more manageable services. These new .planning/codebase Markdown files detail the project's architecture, codebase concerns, coding conventions, external integrations, technology stack, codebase structure, and testing patterns. Additionally, the pull request updates the Claude Agent SDK and OpenAI Codex SDK versions, modifies the Dockerfile to pre-install Playwright Chromium for automated AI agent verification tests (with corresponding README.md updates), and updates the CLAUDE.md model alias for 'opus' to claude-opus-4-6. Core server logic changes include updating the AutoModeService to use a new AutoModeServiceCompat layer, which acts as a compatibility shim for the refactored auto-mode services, and enhancing Claude authentication detection with more detailed logging. The sdk-options.ts and claude-provider.ts files are updated to support adaptive thinking for Claude Opus 4.6 by conditionally omitting maxThinkingTokens. The claude-usage-service.ts now includes improved ANSI code stripping for better parsing of Claude CLI output, and codex-models.ts is updated with new GPT-5.3-Codex model definitions. Several new services (AgentExecutor, AutoLoopCoordinator, ConcurrencyManager, ExecutionService, FeatureStateManager, MergeService, PipelineOrchestrator, PlanApprovalService, RecoveryService, TypedEventBus, WorktreeResolver) are introduced to modularize the AutoModeService functionality, with corresponding type definitions and callback interfaces. The TaskProgressPanel in the UI is updated to correctly reflect task statuses based on persisted data and individual task status events, rather than relying on a heuristic. Finally, the eslint.config.mjs is updated to include queueMicrotask as a readonly global, and the SandboxRiskDialog in the UI now provides troubleshooting steps for Docker users.
Improve recovery of tasks after a server restart
Summary by CodeRabbit
New Features
Bug Fixes & Improvements
Documentation