-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Java demo with tutorial update #56
base: java
Are you sure you want to change the base?
Conversation
retried the way to define endpoint by web.xml, use urlPatterns of WebServlet now
Hi guys, the very first thing I noticed here is that the PR was trying to merge the changes into |
src/main/java/oss.java
Outdated
@@ -37,7 +42,7 @@ protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws Se | |||
if (id.equals("#")) {// root | |||
BucketsApi bucketsApi = new BucketsApi(); | |||
|
|||
ApiResponse<Buckets> buckets = bucketsApi.getBuckets("us", 100, null, forgeOAuth, | |||
ApiResponse<Buckets> buckets = bucketsApi.getBuckets("us", 100, "abc", forgeOAuth, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the "abc"
parameter mean here? According to the docs, the 3rd param is:
Key to use as an offset to continue pagination This is typically the last bucket key found in a preceding GET buckets response
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it is an error, need to be fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This issue is from the original version of JAVA tutorial. done. fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the "abc"
thing the code looks good.
the most change is : retried the way to define endpoint by web.xml, use urlPatterns of WebServlet now