fix: parsing when there are nested quotes

[sjinks]

This PR attempts to fix the parsing of command-line arguments.

VIP CLI is expected to quote arguments correctly (e.g., enclosing them in double quotes and replacing inner quotes with \"). If it isn't (e.g., an evil hacker is playing around), "purgamentum init, exit purgamentum" rule is applied. This will cause commands to fail because we invoke WP CLI directly, not via a shell.

The "unquoting" logic is simple: for every argument,

• if it is enclosed with single quotes, remove them;
• if it is enclosed with double quotes, remove them and replace \" with ";
• otherwise, if the parameter matches the ^--[a-zA-Z0-9_-]+=".*"$ regex, remove quotes around the value (this accounts for VIP CLI quoting bug);
• otherwise, use the value as is.

Related: BB8-12231

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)

• go.mod: Language not supported

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

remote/remote.go:367

• The removal of error handling in getCleanWpCliArgumentArray might lead to unhandled errors if the input string is malformed.

func getCleanWpCliArgumentArray(wpCliCmdString string) []string {

remote/remote_test.go:77

• The test case for unbalanced quotes is not adequately covered. Consider adding more test cases to handle different scenarios of unbalanced quotes.

"unbalanced quotes (2)": {want: []string{`a" 'b`}, input: `a" 'b`},

[rinatkhaziev]

Awesome but scary but awesome.

❤️ the tests.

Will definitely need to consider slow rollout strategy when deploying.